Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid config export errors #16834

Merged
merged 3 commits into from
Sep 4, 2020
Merged

Fix invalid config export errors #16834

merged 3 commits into from
Sep 4, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 3, 2020

This corrects detecting of invalid page config exports and adds additional test cases for non-invalid config import/exports

Closes: #16775

@ijjk ijjk added the type: next label Sep 3, 2020
@ijjk
Copy link
Member Author

ijjk commented Sep 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
buildDuration 13.2s 13.5s ⚠️ +358ms
nodeModulesSize 56.7 MB 56.7 MB ⚠️ +2.16 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.49 2.456 -0.03
/ avg req/sec 1003.9 1017.85 +13.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.488 1.46 -0.03
/error-in-render avg req/sec 1680.07 1711.83 +31.76
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..b5de.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ec49a3f..d437.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..dule.js gzip 6.4 kB 6.4 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-b3aecf0..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
buildDuration 14.4s 14.5s ⚠️ +118ms
nodeModulesSize 56.7 MB 56.7 MB ⚠️ +2.16 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..b5de.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ec49a3f..d437.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..dule.js gzip 6.4 kB 6.4 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-b3aecf0..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: 9cf9647

@ijjk
Copy link
Member Author

ijjk commented Sep 4, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
buildDuration 10.7s 11.3s ⚠️ +633ms
nodeModulesSize 56.7 MB 56.7 MB ⚠️ +2.16 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.978 1.937 -0.04
/ avg req/sec 1263.76 1290.97 +27.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.055 1.125 ⚠️ +0.07
/error-in-render avg req/sec 2369.21 2221.57 ⚠️ -147.64
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..b5de.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ec49a3f..d437.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..dule.js gzip 6.4 kB 6.4 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-b3aecf0..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 963 B 963 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
buildDuration 12.2s 13s ⚠️ +760ms
nodeModulesSize 56.7 MB 56.7 MB ⚠️ +2.16 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..b5de.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ec49a3f..d437.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
677f882d2ed8..dule.js gzip 6.4 kB 6.4 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-b3aecf0..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/invalid-config-exports Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: 7528984

@kodiakhq kodiakhq bot merged commit d97237a into vercel:canary Sep 4, 2020
@ijjk ijjk deleted the fix/invalid-config-exports branch September 4, 2020 14:11
@laugharn laugharn mentioned this pull request Sep 9, 2020
Closed
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@ijjk
Fix invalid config export errors (vercel#16834)
0992642 
This corrects detecting of invalid page config exports and adds additional test cases for non-invalid config import/exports

Closes: vercel#16775
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import config in _app raises https://err.sh/vercel/next.js/invalid-page-config
2 participants
@ijjk @timneutkens