Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor spelling fix in zones example's readme #16822

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Minor spelling fix in zones example's readme #16822

merged 1 commit into from
Sep 3, 2020

Conversation

gsimone
Copy link
Contributor

@gsimone gsimone commented Sep 3, 2020

No description provided.

@ijjk ijjk added the examples Issue/PR related to examples label Sep 3, 2020
@ijjk
Copy link
Member

ijjk commented Sep 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary gsimone/next.js patch-1 Change
buildDuration 13.4s 13.4s ⚠️ +16ms
nodeModulesSize 55.9 MB 55.9 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary gsimone/next.js patch-1 Change
/ failed reqs 0 0
/ total time (seconds) 2.426 2.357 -0.07
/ avg req/sec 1030.32 1060.58 +30.26
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.263 1.299 ⚠️ +0.04
/error-in-render avg req/sec 1979.29 1924.5 ⚠️ -54.79
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js patch-1 Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f69b135..640b.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary gsimone/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary gsimone/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Rendered Page Sizes
vercel/next.js canary gsimone/next.js patch-1 Change
index.html gzip 972 B 972 B
link.html gzip 978 B 978 B
withRouter.html gzip 964 B 964 B
Overall change 2.91 kB 2.91 kB

Serverless Mode
General
vercel/next.js canary gsimone/next.js patch-1 Change
buildDuration 15.1s 15.1s ⚠️ +2ms
nodeModulesSize 55.9 MB 55.9 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary gsimone/next.js patch-1 Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB
framework.HASH.js gzip 39 kB 39 kB
main-f69b135..640b.js gzip 7.1 kB 7.1 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 57.3 kB 57.3 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary gsimone/next.js patch-1 Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.3 kB 52.3 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary gsimone/next.js patch-1 Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary gsimone/next.js patch-1 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.71 kB 7.71 kB
Client Pages Modern
vercel/next.js canary gsimone/next.js patch-1 Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.36 kB 5.36 kB
Client Build Manifests
vercel/next.js canary gsimone/next.js patch-1 Change
_buildManifest.js gzip 322 B 322 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 651 B 651 B
Serverless bundles
vercel/next.js canary gsimone/next.js patch-1 Change
_error.js 1.03 MB 1.03 MB
404.html 4.22 kB 4.22 kB
hooks.html 3.86 kB 3.86 kB
index.js 1.03 MB 1.03 MB
link.js 1.08 MB 1.08 MB
routerDirect.js 1.07 MB 1.07 MB
withRouter.js 1.07 MB 1.07 MB
Overall change 5.29 MB 5.29 MB
Commit: b38c842

Copy link

@uchibeke uchibeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♠️ LGTM

@kodiakhq kodiakhq bot merged commit 4048d29 into vercel:canary Sep 3, 2020
@gsimone gsimone deleted the patch-1 branch September 3, 2020 16:37
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants