Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(examples/with-react-intl): add locale negotation to client side #16806

Merged
merged 3 commits into from
Sep 16, 2020
Merged

feat(examples/with-react-intl): add locale negotation to client side #16806

merged 3 commits into from
Sep 16, 2020

Conversation

longlho
Copy link
Contributor

@longlho longlho commented Sep 3, 2020

@ijjk ijjk added the examples Issue/PR related to examples label Sep 3, 2020
@ijjk
Copy link
Member

ijjk commented Sep 3, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 13s 12.9s -66ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary longlho/next.js intl Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.482 2.382 -0.1
/ avg req/sec 1007.45 1049.7 +42.25
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.464 1.419 -0.04
/error-in-render avg req/sec 1707.32 1762.19 +54.87
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary longlho/next.js intl Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 978 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 14.3s 14.1s -235ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary longlho/next.js intl Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: f4df67f

@ijjk
Copy link
Member

ijjk commented Sep 6, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 11.2s 11.2s -20ms
nodeModulesSize 56.7 MB 56.7 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary longlho/next.js intl Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.956 1.999 ⚠️ +0.04
/ avg req/sec 1278.43 1250.54 ⚠️ -27.89
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.102 1.163 ⚠️ +0.06
/error-in-render avg req/sec 2269.22 2149.8 ⚠️ -119.42
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..bdc4.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0109a22..a8e8.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.41 kB 6.41 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8b2bf21..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary longlho/next.js intl Change
index.html gzip 972 B 972 B ✓
link.html gzip 977 B 977 B ✓
withRouter.html gzip 961 B 961 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 12.6s 12.7s ⚠️ +93ms
nodeModulesSize 56.7 MB 56.7 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..bdc4.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-0109a22..a8e8.js gzip 7.08 kB 7.08 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.41 kB 6.41 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-8b2bf21..dule.js gzip 6.14 kB 6.14 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary longlho/next.js intl Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: 4ad740d

@longlho
Copy link
Contributor Author

longlho commented Sep 8, 2020 •
edited
Loading

I think this is mergeable right? cc @lfades

lfades
lfades approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@ijjk
Copy link
Member

ijjk commented Sep 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 12.4s 12.1s -333ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary longlho/next.js intl Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.176 2.174 0
/ avg req/sec 1148.87 1149.95 +1.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.264 1.132 -0.13
/error-in-render avg req/sec 1977.66 2209.4 +231.74
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary longlho/next.js intl Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 997 B 997 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary longlho/next.js intl Change
buildDuration 12.8s 12.4s -420ms
nodeModulesSize 62.9 MB 62.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-772ea11..1d22.js gzip 7.16 kB 7.16 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary longlho/next.js intl Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-911f3f8..dule.js gzip 6.23 kB 6.23 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary longlho/next.js intl Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary longlho/next.js intl Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary longlho/next.js intl Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary longlho/next.js intl Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary longlho/next.js intl Change
_error.js 1.04 MB 1.04 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.04 MB 1.04 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.08 MB 1.08 MB ✓
withRouter.js 1.08 MB 1.08 MB ✓
Overall change 5.31 MB 5.31 MB ✓
Commit: 5d55074

@kodiakhq kodiakhq bot merged commit 67b67b2 into vercel:canary Sep 16, 2020
@longlho longlho deleted the intl branch September 17, 2020 00:40
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@longlho
feat(examples/with-react-intl): add locale negotation to client side (v…
4ccc9a6 
…ercel#16806)

fix vercel#16752

cc @thuringia
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thuringia thuringia thuringia left review comments

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[examples, react-intl] Application cannot be deployed using serverless target (Vercel, Netlify)
4 participants
@longlho @ijjk @thuringia @lfades