Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fast Refresh Demo #16576

Merged
merged 8 commits into from
Sep 1, 2020
Merged

Add Fast Refresh Demo #16576

merged 8 commits into from
Sep 1, 2020

Conversation

YichiZ
Copy link
Contributor

@YichiZ YichiZ commented Aug 26, 2020 •
edited
Loading

Closes #16538

Basically reverts #16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.

@YichiZ
Revert (#16497) + changes
af9b5d1 
This reverts commit ec281df.
@ijjk ijjk added the examples Issue/PR related to examples label Aug 26, 2020
@ijjk
Copy link
Member

ijjk commented Aug 26, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13.4s 14.3s ⚠️ +851ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.533 2.625 ⚠️ +0.09
/ avg req/sec 986.82 952.56 ⚠️ -34.26
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.566 1.559 -0.01
/error-in-render avg req/sec 1596.6 1603.43 +6.83
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4bab31..824e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-438d30a..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 948 B 948 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 15.8s 15.8s ⚠️ +5ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d4bab31..824e.js gzip 7.34 kB 7.34 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-438d30a..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: af9b5d1

@ijjk
Copy link
Member

ijjk commented Aug 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 12.3s 12.4s ⚠️ +125ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.238 2.205 -0.03
/ avg req/sec 1116.99 1133.7 +16.71
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.235 1.214 -0.02
/error-in-render avg req/sec 2024.74 2059.32 +34.58
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-da593e2..abf1.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34d17c2..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 972 B 972 B ✓
link.html gzip 979 B 979 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.92 kB 2.92 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13.9s 13.3s -620ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-da593e2..abf1.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34d17c2..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 9a7cfdc

@ijjk
Copy link
Member

ijjk commented Aug 26, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13.6s 13.8s ⚠️ +254ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.596 2.615 ⚠️ +0.02
/ avg req/sec 962.84 956.01 ⚠️ -6.83
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.51 1.586 ⚠️ +0.08
/error-in-render avg req/sec 1655.57 1575.88 ⚠️ -79.69
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-da593e2..abf1.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34d17c2..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 972 B 972 B ✓
link.html gzip 979 B 979 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.92 kB 2.92 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 16.1s 15.6s -430ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-da593e2..abf1.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-34d17c2..dule.js gzip 6.39 kB 6.39 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: dfdadd1

@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13s 13s -52ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.311 2.395 ⚠️ +0.08
/ avg req/sec 1081.6 1043.84 ⚠️ -37.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.235 1.292 ⚠️ +0.06
/error-in-render avg req/sec 2023.83 1935.72 ⚠️ -88.11
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 978 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 14.7s 14.1s -663ms
nodeModulesSize 57.5 MB 57.5 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.36 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 3eabf99

lfades
lfades requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested until I can get some time to update the content in the example. I want to add instructions in the pages about how updating the code will affect the page, instead of just providing a component without context.

@lfades lfades self-assigned this Aug 27, 2020
@YichiZ
Copy link
Contributor Author

YichiZ commented Aug 28, 2020

@lfades Sure, free free to do so.

If I can assist in any way let me know

@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 12.8s 12.8s ⚠️ +27ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.273 2.271 0
/ avg req/sec 1099.69 1101.08 +1.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.228 1.249 ⚠️ +0.02
/error-in-render avg req/sec 2035.83 2002.14 ⚠️ -33.69
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2063496..a4a5.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1e9d4f5..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 972 B 972 B ✓
link.html gzip 975 B 975 B ✓
withRouter.html gzip 965 B 965 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 14.3s 14.5s ⚠️ +181ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2063496..a4a5.js gzip 7.32 kB 7.32 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-1e9d4f5..dule.js gzip 6.38 kB 6.38 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: d714639

lfades
lfades approved these changes Sep 1, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YichiZ Thank you!

@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13.2s 13.3s ⚠️ +106ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.503 2.493 -0.01
/ avg req/sec 998.9 1002.91 +4.01
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.57 1.573 0
/error-in-render avg req/sec 1592.82 1588.99 ⚠️ -3.83
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-830c506..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 965 B 965 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 15.2s 15.3s ⚠️ +79ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-830c506..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 757e40c

@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 11.6s 11.8s ⚠️ +243ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.155 2.123 -0.03
/ avg req/sec 1159.98 1177.64 +17.66
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.196 1.175 -0.02
/error-in-render avg req/sec 2090.56 2126.85 +36.29
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-830c506..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
index.html gzip 971 B 971 B ✓
link.html gzip 976 B 976 B ✓
withRouter.html gzip 965 B 965 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
buildDuration 13.1s 13.3s ⚠️ +151ms
nodeModulesSize 55.9 MB 55.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-b338f5a..3500.js gzip 7.31 kB 7.31 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-830c506..dule.js gzip 6.37 kB 6.37 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.2 kB 52.2 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary YichiZ/next.js add-fast-refresh Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 651b292

@kodiakhq kodiakhq bot merged commit 9e4bb5a into vercel:canary Sep 1, 2020
@YichiZ YichiZ deleted the add-fast-refresh branch September 2, 2020 00:05
ijjk pushed a commit to ijjk/next.js that referenced this pull request Sep 2, 2020
@YichiZ @ijjk
Add Fast Refresh Demo (vercel#16576)
936d3f3 
Closes vercel#16538 

Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@YichiZ
Add Fast Refresh Demo (vercel#16576)
251b0e7 
Closes vercel#16538 

Basically reverts vercel#16497 and some minor changes. Also adds a link in the docs.

This reverts commit ec281df.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

@lfades lfades

Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Fast Refresh demo to examples and docs
3 participants
@YichiZ @ijjk @lfades