Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 13.0.4-canary.3 can't find page.tsx in app dir with next dev #43019

Closed
1 task done
Chia1104 opened this issue Nov 17, 2022 · 5 comments · Fixed by #43022 or #43057
Closed
1 task done

🐛 13.0.4-canary.3 can't find page.tsx in app dir with next dev #43019

Chia1104 opened this issue Nov 17, 2022 · 5 comments · Fixed by #43022 or #43057
Labels
bug Issue was opened via the bug report template.

Comments

@Chia1104
Copy link

Verify canary release

  • I verified that the issue exists in the latest Next.js canary release

Provide environment information

  • Operating System:
  1. Platform: win32
  2. Arch: x64
  3. Version: Windows 10 Pro
  • Binaries:
  1. Node: 16.15.1
  2. npm: N/A
  3. Yarn: N/A
  4. pnpm: N/A
  • Relevant packages:
  1. next: 13.0.4-canary.3
  2. eslint-config-next: N/A
  3. react: 18.2.0
  4. react-dom: 18.2.0

What browser are you using? (if relevant)

not relevant

How are you deploying your application? (if relevant)

not relevant

Describe the Bug

13.0.4-canary.3 work incorrectly with next dev, because index.tsx just be found in pages folder.
But next do check the conflict if I put the page.tsx in the root of app folder.
However page.tsx still can't be found, it will return 404 page in the browser.

pages/index.tsx with next dev
13.0.4-canary.3-bug

app/page.tsx or app/(main)/page.tsx with next dev
13.0.4-canary.3-bug2

But appDir work fine in production build on vercel

Expected Behavior

The route system should work correctly in 13.0.4-canary.3

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

https://github.com/Chia1104/with-next-13.0.4-canary.3

To Reproduce

given above
@Chia1104 Chia1104 added the bug Issue was opened via the bug report template. label Nov 17, 2022
@BWBama85
Copy link

Same

@ijjk ijjk mentioned this issue Nov 17, 2022
Merged
11 tasks
ijjk added a commit that referenced this issue Nov 17, 2022
@ijjk
Fix app page check on windows (#43022)
8e7c45b 
Ensures we check for backslashes as well when matching `/page`. Will
investigate adding the app suite to windows CI in follow-up

x-ref: #42996
Fixes: #43019

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
@ijjk
Copy link
Member

ijjk commented Nov 17, 2022

Hi, this has been updated in v13.0.4-canary.4, please update and give it a try!

@BWBama85
Copy link

BWBama85 commented Nov 17, 2022 •
edited
Loading

Hi, this has been updated in v13.0.4-canary.4, please update and give it a try!

Still 404s for me on all pages.

This is only error:

wait  - compiling /_error (client and server)...

    Operating System:
      Platform: win32
      Arch: x64
      Version: Windows 10 Pro
    Binaries:
      Node: 18.12.0
      npm: N/A
      Yarn: N/A
      pnpm: N/A
    Relevant packages:
      next: 13.0.4-canary.4
      eslint-config-next: 13.0.3
      react: 18.2.0
      react-dom: 18.2.0

@ijjk ijjk mentioned this issue Nov 18, 2022
Merged
3 tasks
ijjk added a commit that referenced this issue Nov 18, 2022
@ijjk
Ensure backslash is correctly handled in find-page-file (#43057)
22b16e1 
## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

Fixes:
#43019 (comment)
@ijjk
Copy link
Member

ijjk commented Nov 18, 2022

Ah I see thanks for confirm, corrected in v13.0.4-canary.5 of Next.js

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Milestone
No milestone
3 participants
@ijjk @Chia1104 @BWBama85