-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report @next/next/no-img-element when inside a <Picture> element #37504
Comments
Thanks, sounds like a change is needed in this ESLint rule: And adding a test use-case in this folder to verify it works correctly: https://github.com/vercel/next.js/tree/canary/test/integration/eslint |
Hi! Can I pick up this issue? Or @votemike were you planning to do it? |
@andreistefanwork go for it! |
This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you. |
Verify canary release
Provide environment information
What browser are you using? (if relevant)
How are you deploying your application? (if relevant)
Describe the Bug
Linting throws a warning of
@next/next/no-img-element
when an<img>
tag is inside a<picture>
tag.<Image>
cannot do all the things that<picture>
can and so using the<img>
is a legitimate use-case.Therefore this warning should not be thrown.
Expected Behavior
Linting ignores
<img>
tags inside<picture>
tags.To Reproduce
Add an
<img>
tag inside a<picture>
tag and run linting.The text was updated successfully, but these errors were encountered: