Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with-algolia example is not SSR as doc stated #17229

Closed
ivawzh opened this issue Sep 19, 2020 · 1 comment · Fixed by #17347
Closed

with-algolia example is not SSR as doc stated #17229

ivawzh opened this issue Sep 19, 2020 · 1 comment · Fixed by #17347
Labels
good first issue Easy to fix issues, good for newcomers

Comments

@ivawzh
Copy link

ivawzh commented Sep 19, 2020

Bug report

Describe the bug

I stuck the whole night and couldn't understand how the Algolia example is SSR as its README.md stated.

next.js/examples/with-algolia-react-instantsearch/README.md

Line 3 in c03d493

The goal of this example is to illustrate how you can use [Algolia React InstantSearch](https://community.algolia.com/react-instantsearch/) to perform your search with a Server-rendered application developed with Next.js. It also illustrates how you can keep in sync the Url with the search.

After all, it's just not SSR at all 👉 #14233 (comment)

Can you please either make it clear it's not SSR on README or update the example implementation to make it SSR?
@timneutkens timneutkens added the good first issue Easy to fix issues, good for newcomers label Sep 21, 2020
@rishi-raj-jain rishi-raj-jain mentioned this issue Sep 24, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #17347 Sep 25, 2020
kodiakhq bot pushed a commit that referenced this issue Sep 25, 2020
Update README.md (#17347)
92fc260 
As clear from [#14233](#14233 (comment)) that the 'with-algolia example is not SSR', I've updated the documentation to clear the confusion caused, as visible in #17229 

Fixes #17229
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this issue Sep 26, 2020
Update README.md (vercel#17347)
bfec550 
As clear from [vercel#14233](vercel#14233 (comment)) that the 'with-algolia example is not SSR', I've updated the documentation to clear the confusion caused, as visible in vercel#17229 

Fixes vercel#17229
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md
3 participants
@ivawzh @timneutkens @balazsorban44