Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Click-to-open error state for development overlay #14461

Closed
Timer opened this issue Jun 22, 2020 · 4 comments · Fixed by #21819
Closed

Click-to-open error state for development overlay #14461

Timer opened this issue Jun 22, 2020 · 4 comments · Fixed by #21819
Labels
good first issue Easy to fix issues, good for newcomers
Milestone
backlog

Comments

@Timer
Copy link
Member

Timer commented Jun 22, 2020

When the click-to-open feature fails in the development overlay, we should provide a friendly error state that explains what went wrong. Currently, the failure is handled silently.
@Timer Timer added good first issue Easy to fix issues, good for newcomers kind: story labels Jun 22, 2020
@Timer Timer added this to the backlog milestone Jun 22, 2020
@chuabingquan
Copy link
Contributor

chuabingquan commented Jun 23, 2020 •
edited
Loading

Hey @Timer, I can give this a shot! Could you share a screenshot of how the click-to-open feature looks like?

@chuabingquan chuabingquan mentioned this issue Jun 29, 2020
Closed
@chuabingquan
Copy link
Contributor

I've made a PR, do let me know what changes are needed!

@yang-feng-yfeng
Copy link
Contributor

Hey @Timer , I just made a PR on this, could you please check that?

@yang-feng-yfeng yang-feng-yfeng mentioned this issue Feb 3, 2021
Merged
timneutkens pushed a commit that referenced this issue Nov 17, 2021
@yang-feng-yfeng
Click-to-open error state for development overlay #14461 (#21819)
06770e4
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
backlog
4 participants
@Timer @chuabingquan @balazsorban44 @yang-feng-yfeng