Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

next/head causes issue when rendered outside of Next.js #14425

Closed
timneutkens opened this issue Jun 21, 2020 · 1 comment · Fixed by #14511
Closed

next/head causes issue when rendered outside of Next.js #14425

timneutkens opened this issue Jun 21, 2020 · 1 comment · Fixed by #14511
Assignees
@ijjk
Milestone
iteration 3

Comments

@timneutkens
Copy link
Member

have to switch back to the stable version :( the canary version has problems with rendering by testing-library/react

this.props.headManager.mountedInstances.add(this); mountedInstances is undefined

Originally posted by @coolgk in #8841 (comment)
@timneutkens timneutkens added this to the iteration 3 milestone Jun 21, 2020
@timneutkens timneutkens mentioned this issue Jun 21, 2020
Closed
@Timer Timer mentioned this issue Jun 22, 2020
Closed
@ijjk ijjk mentioned this issue Jun 23, 2020
Merged
@kodiakhq kodiakhq bot closed this as completed in #14511 Jun 23, 2020
kodiakhq bot pushed a commit that referenced this issue Jun 23, 2020
@ijjk
Handle rendering next/head outside of Next.js (#14511)
5bb081f 
This ensures `next/head` doesn't fail to render when being rendered during tests or outside of Next.js' tree

Closes: #14425
rokinsky pushed a commit to rokinsky/next.js that referenced this issue Jul 11, 2020
@ijjk @rokinsky
Handle rendering next/head outside of Next.js (vercel#14511)
cb9631b 
This ensures `next/head` doesn't fail to render when being rendered during tests or outside of Next.js' tree

Closes: vercel#14425
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ijjk ijjk

Labels
None yet
Projects
None yet
Milestone
iteration 3
Development

Successfully merging a pull request may close this issue.

Handle rendering next/head outside of Next.js ijjk/next.js
3 participants
@timneutkens @balazsorban44 @ijjk