Merge branch 'canary' into update/turbo

vercel · May 19, 2022 · 63f5828 · 63f5828
2 parents ae808da + 9732463
commit 63f5828
Show file tree

Hide file tree

Showing 10 changed files with 66 additions and 27 deletions.
diff --git a/packages/next-swc/Cargo.lock b/packages/next-swc/Cargo.lock
diff --git a/packages/next-swc/crates/core/Cargo.toml b/packages/next-swc/crates/core/Cargo.toml
@@ -21,9 +21,9 @@ swc_emotion = {path="../emotion"}
 styled_components = {path="../styled_components"}
 styled_jsx = {path="../styled_jsx"}
 modularize_imports = {path="../modularize_imports"}
-swc = "0.180.0"
+swc = "0.181.0"
 swc_atoms = "0.2.11"
-swc_common = { version = "0.18.2", features = ["concurrent", "sourcemap"] }
+swc_common = { version = "0.18.5", features = ["concurrent", "sourcemap"] }
 swc_ecma_loader = { version = "0.30.1", features = ["node", "lru"] }
 swc_ecmascript = { version = "0.157.0", features = ["codegen", "minifier", "optimization", "parser", "react", "transforms", "typescript", "utils", "visit"] }
 swc_cached = "0.1.1"

diff --git a/packages/next-swc/crates/emotion/Cargo.toml b/packages/next-swc/crates/emotion/Cargo.toml
@@ -19,7 +19,7 @@ regex = "1.5"
 serde = "1"
 sourcemap = "6.0.1"
 swc_atoms = "0.2.11"
-swc_common = { version = "0.18.2", features = ["concurrent", "sourcemap"] }
+swc_common = { version = "0.18.5", features = ["concurrent", "sourcemap"] }
 swc_ecmascript = { version = "0.157.0", features = ["codegen", "utils", "visit"] }
 swc_trace_macro = "0.1.1"
 tracing = { version = "0.1.32", features = ["release_max_level_info"] }

diff --git a/packages/next-swc/crates/napi/Cargo.toml b/packages/next-swc/crates/napi/Cargo.toml
@@ -17,10 +17,10 @@ next-swc = {version = "0.0.0", path = "../core"}
 once_cell = "1.8.0"
 serde = "1"
 serde_json = "1"
-swc = "0.180.0"
+swc = "0.181.0"
 swc_atoms = "0.2.11"
 swc_bundler = { version = "0.147.0", features = ["concurrent"] }
-swc_common = { version = "0.18.2", features = ["concurrent", "sourcemap"] }
+swc_common = { version = "0.18.5", features = ["concurrent", "sourcemap"] }
 swc_ecma_loader = { version = "0.30.1", features = ["node", "lru"] }
 swc_ecmascript = { version = "0.157.0", features = ["codegen", "minifier", "optimization", "parser", "react", "transforms", "typescript", "utils", "visit"] }
 swc_node_base = "0.5.3"

diff --git a/packages/next-swc/crates/styled_components/Cargo.toml b/packages/next-swc/crates/styled_components/Cargo.toml
@@ -16,7 +16,7 @@ once_cell = "1.10.0"
 regex = {version = "1.5.4", features = ["std", "perf"], default-features = false}
 serde = {version = "1.0.130", features = ["derive"]}
 swc_atoms = "0.2.11"
-swc_common = { version = "0.18.2", features = ["concurrent"] }
+swc_common = { version = "0.18.5", features = ["concurrent"] }
 swc_ecmascript = { version = "0.157.0", features = ["utils", "visit"] }
 tracing = "0.1.32"
 

diff --git a/packages/next-swc/crates/styled_jsx/Cargo.toml b/packages/next-swc/crates/styled_jsx/Cargo.toml
@@ -11,7 +11,7 @@ version = "0.4.0"
 
 [dependencies]
 easy-error = "1.0.0"
-swc_common = { version = "0.18.2", features = ["concurrent", "sourcemap"] }
+swc_common = { version = "0.18.5", features = ["concurrent", "sourcemap"] }
 swc_css = "0.105.0"
 swc_css_prefixer = "0.101.0"
 swc_ecmascript = { version = "0.157.0", features = ["parser", "minifier", "utils", "visit"] }

diff --git a/packages/next-swc/crates/wasm/Cargo.toml b/packages/next-swc/crates/wasm/Cargo.toml
@@ -16,8 +16,8 @@ parking_lot_core = "=0.8.0"
 path-clean = "0.1"
 serde = {version = "1", features = ["derive"]}
 serde_json = "1"
-swc = "0.180.0"
-swc_common = { version = "0.18.2", features = ["concurrent", "sourcemap"] }
+swc = "0.181.0"
+swc_common = { version = "0.18.5", features = ["concurrent", "sourcemap"] }
 swc_ecmascript = { version = "0.157.0", features = ["codegen", "minifier", "optimization", "parser", "react", "transforms", "typescript", "utils", "visit"] }
 tracing = { version = "0.1.32", features = ["release_max_level_off"] }
 wasm-bindgen = {version = "0.2", features = ["serde-serialize"]}

diff --git a/packages/next/pages/_document.tsx b/packages/next/pages/_document.tsx
@@ -555,8 +555,13 @@ export class Head extends Component<
           !script.src && (script.dangerouslySetInnerHTML || script.children)
       )
       .map((file: ScriptProps, index: number) => {
-        const { strategy, children, dangerouslySetInnerHTML, ...scriptProps } =
-          file
+        const {
+          strategy,
+          children,
+          dangerouslySetInnerHTML,
+          src,
+          ...scriptProps
+        } = file
         let html = ''
 
         if (dangerouslySetInnerHTML && dangerouslySetInnerHTML.__html) {

diff --git a/test/integration/script-loader/base/pages/page7.js b/test/integration/script-loader/base/pages/page7.js
@@ -0,0 +1,15 @@
+import Script from 'next/script'
+
+const Page = () => {
+  return (
+    <div class="container">
+      <Script
+        id="beforeInteractiveInlineScript"
+        strategy="beforeInteractive"
+      >{`console.log('beforeInteractive inline script run')`}</Script>
+      <div>page7</div>
+    </div>
+  )
+}
+
+export default Page
diff --git a/test/integration/script-loader/test/index.test.js b/test/integration/script-loader/test/index.test.js
@@ -203,6 +203,24 @@ describe('Next.js Script - Primary Strategies', () => {
     ).toBeGreaterThan(0)
   })
 
+  it('priority beforeInteractive with inline script should execute', async () => {
+    let browser
+    try {
+      browser = await webdriver(appPort, '/page7')
+
+      await waitFor(1000)
+
+      const logs = await browser.log()
+      expect(
+        logs.some((log) =>
+          log.message.includes('beforeInteractive inline script run')
+        )
+      ).toBe(true)
+    } finally {
+      if (browser) await browser.close()
+    }
+  })
+
   it('Does not duplicate inline scripts', async () => {
     let browser
     try {