-
Notifications
You must be signed in to change notification settings - Fork 26.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
next-swc: fix ssg code elimination when used in render (#32709)
* next-swc: fix ssg code elimination when used in render * simplify logic and add more thorough tests * comment * remove fold_export_default and fix JSX member expression
- Loading branch information
Showing
3 changed files
with
78 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
...es/core/tests/fixture/ssg/getStaticProps/should-not-remove-import-used-in-render/input.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import { useState, useEffect } from 'react' | ||
import { Root, Children, JSXMemberExpression, AttributeValue, AttributeJSX, ValueInRender, ValueInEffect, UnusedInRender } from '../' | ||
|
||
export default function Test() { | ||
const [x, setX] = useState(ValueInRender.value) | ||
useEffect(() => { | ||
setX(ValueInEffect.value) | ||
}, []) | ||
|
||
return ( | ||
<Root x={x}> | ||
<div> | ||
<Children attr={AttributeValue} jsx={<AttributeJSX />} /> | ||
<JSXMemberExpression.Deep.Property /> | ||
</div> | ||
</Root> | ||
) | ||
} | ||
|
||
export async function getStaticProps() { | ||
return { | ||
props: { | ||
// simulate import usage inside getStaticProps | ||
used: [ | ||
// these import references should not be removed | ||
Root.value, | ||
Children.value, | ||
AttributeValue.value, | ||
AttributeJSX.value, | ||
ValueInRender.value, | ||
ValueInEffect.value, | ||
JSXMemberExpression.value, | ||
// this import reference should be removed | ||
UnusedInRender.value, | ||
], | ||
} | ||
} | ||
} |
15 changes: 15 additions & 0 deletions
15
...s/core/tests/fixture/ssg/getStaticProps/should-not-remove-import-used-in-render/output.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
import { useState, useEffect } from "react"; | ||
import { Root, Children, JSXMemberExpression, AttributeValue, AttributeJSX, ValueInRender, ValueInEffect } from "../"; | ||
export var __N_SSG = true; | ||
export default function Test() { | ||
const [x, setX] = useState(ValueInRender.value); | ||
useEffect(() => { | ||
setX(ValueInEffect.value); | ||
}, []) | ||
return __jsx(Root, { | ||
x: x | ||
}, __jsx('div', null, __jsx(Children, { | ||
attr: AttributeValue, | ||
jsx: __jsx(AttributeJSX, null) | ||
}), __jsx(JSXMemberExpression.Deep.Property, null))); | ||
} |