Skip to content

Commit

Permalink
Remove deprecated plugin in favor of the option (#14503)
Browse files Browse the repository at this point in the history
Not sure if it's still there for a reason, but from  the types for `NoEmitOnErrorsPlugin`
```js
/* @deprecated use config.optimization.noEmitOnErrors */
```
  • Loading branch information
Janpot committed Jun 23, 2020
1 parent be2a632 commit 574e9d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/next/build/webpack-config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -634,6 +634,7 @@ export default async function getBaseWebpackConfig(
'@ampproject/toolbox-optimizer', // except this one
],
optimization: {
noEmitOnErrors: dev,
checkWasmTypes: false,
nodeEnv: false,
splitChunks: isServer ? false : splitChunksConfig,
Expand Down Expand Up @@ -887,7 +888,6 @@ export default async function getBaseWebpackConfig(
} = require('./webpack/plugins/unlink-removed-pages-plugin')
const devPlugins = [
new UnlinkRemovedPagesPlugin(),
new webpack.NoEmitOnErrorsPlugin(),
new NextJsRequireCacheHotReloader(),
]

Expand Down

0 comments on commit 574e9d2

Please sign in to comment.