-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
π Fix copy/paste shortcuts on Windows/Linux π #1406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm! π
I think you should release a new build as a fix when this pull had been merged |
Hi, how can I apply this fix on my currently installed Hyper? I'm having this precise copy/paste issue! |
@prubini87 you can cherry-pick the commit and build Hyper localy. |
Ah, kk @stefanivic, thanks for your quick reply! π |
I'm sorry, but am I new to this, any detailed explanation of how to integrate this change into my currently installed Hyper? |
@aneira92 the only options are to build it localy or to wait for a build that will come out sometimes this week. For building localy : |
@stefanivic OK thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm !
Thanks everybody π Will ship it this week π |
Did this make it into Hyper? I'm on Windows 10 and Hyper 2 and |
@wishinghand Did you try |
For some reason my mind wasn't seeing the |
was this just fixed or? do I have to build manually? on windows and pasting don't work :'( |
omg gyazo was capturing the shortcut fml |
if you wanna change the default commands, you can set at ...
keymaps: {
"editor:copy": "ctrl+c",
"editor:paste": "ctrl+v"
} |
This PR fixes the copy and paste shortcuts for Windows and Linux π΅οΈ
There was two problems:
Ctrl
was pressed β you couldn't copy anythinghyper-caret
was always being focused, even when it was already inserted into thecursor-node
. This was preventing both copy and paste shortcuts from workingCloses #1328, #1381, #1394