-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text deselect #1218
Fix text deselect #1218
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Havn't tested this myself, but the code looks 🆗
This is still not fixed on MacOS at least. First of all, e.code is In case anyone is interested I changed the test to: |
On MacOS this work perfectly. This is not released yet. If you still have a problem. feel free to make a gif. With your specific use case. |
I was hacking on it in dev mode using the repo master branch. A production build to dist doesn't work for me, it won't open a new window. Anyhoo, I'm fine waiting for the next official release. Thanks again. |
@@ -213,20 +213,22 @@ hterm.Keyboard.prototype.onKeyDown_ = function (e) { | |||
|
|||
if (e.altKey || e.metaKey || isAccelerator(e)) { | |||
// hterm shouldn't consume a hyper accelerator | |||
// // Was the hyperCaret removed for selectAll | |||
if (e.key === 'v' && !this.terminal.cursorNode_.contains(this.hyperCaret)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ppot why this is here? 🤔
spans that have white background color are still obfuscated... I had to google this issue, sorry if this isn't the right place to moan about this. This fixes all of the white-against-white issues:
|
with |
If you have issue. We recommend creating new one and linking it to the closed one. |
Close #819