Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP1056Registry - standardized contract interface #60

Merged
merged 8 commits into from
Nov 2, 2023
Merged

EIP1056Registry - standardized contract interface #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9699ae9
rename EthereumDIDRegistry to DIDRegistry
jac18281828 Oct 18, 2023
28e275e
upgrade solidity 0.8.21, upgrade hardhat, simplify Dockerbuild
jac18281828 Oct 18, 2023
ccc4397
Document functions in DIDRegistry contract
jac18281828 Oct 18, 2023
2193520
Add EIP1056Registry
jac18281828 Oct 18, 2023
9f35008
Update packages/did-eth-registry/contracts/DIDRegistry.sol
jac18281828 Oct 30, 2023
6ac08f5
Update packages/did-eth-registry/contracts/EIP1056Registry.sol
jac18281828 Oct 30, 2023
a5b6cf7
Update packages/did-eth-registry/contracts/EIP1056Registry.sol
jac18281828 Oct 30, 2023
0d77ef6
review: rename internal contract functions to include _ to avoid name…
jac18281828 Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions packages/did-eth-registry/.solhint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
{
"extends": "solhint:recommended",
"rules": {
"compiler-version": ["error", "^0.8.0"],
"func-visibility": ["warn", { "ignoreConstructors": true }],
"compiler-version": [
"error",
"^0.8.15"
],
"func-visibility": [
"warn",
{
"ignoreConstructors": true
}
],
"not-rely-on-time": "off"
}
}
}
51 changes: 6 additions & 45 deletions packages/did-eth-registry/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,56 +1,17 @@
FROM debian:stable-slim as python-builder
FROM ghcr.io/xmtp/foundry:latest

# python3.10 is required for node-gyp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.10 is no longer required on the latest hardhat and node versions (solc 0.8.21)

RUN useradd --create-home -s /bin/bash did
RUN usermod -a -G sudo did
RUN echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers

# Python
RUN export DEBIAN_FRONTEND=noninteractive && \
apt update && \
apt install -y -q --no-install-recommends \
npm build-essential curl \
ca-certificates apt-transport-https \
libncursesw5-dev libssl-dev \
libsqlite3-dev tk-dev libgdbm-dev \
libc6-dev libbz2-dev libffi-dev zlib1g-dev \
python3-pip python3-dev && \
python3-pip python3-dev python3 && \
apt clean && \
rm -rf /var/lib/apt/lists/*

WORKDIR /build
ADD https://www.python.org/ftp/python/3.10.13/Python-3.10.13.tgz Python-3.10.13.tgz
RUN tar -xvf Python-3.10.13.tgz
WORKDIR /build/Python-3.10.13
RUN ./configure --enable-optimizations
RUN make -j4

FROM ghcr.io/xmtp/foundry:latest

RUN useradd --create-home -s /bin/bash did
RUN usermod -a -G sudo did
RUN echo '%sudo ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers

# Python 3.10

COPY --from=python-builder /build /build
WORKDIR /build/Python-3.10.13
RUN make install
RUN which python3 && python3 --version
RUN rm -rf /build

RUN mkdir -p /usr/local/nvm
ENV NVM_DIR=/usr/local/nvm

ENV NODE_VERSION=v14.21.3

ADD https://github.com/raw/creationix/nvm/master/install.sh /usr/local/etc/nvm/install.sh
RUN bash /usr/local/etc/nvm/install.sh && \
bash -c ". $NVM_DIR/nvm.sh && nvm install $NODE_VERSION && nvm alias default $NODE_VERSION && nvm use default"

ENV NVM_NODE_PATH ${NVM_DIR}/versions/node/${NODE_VERSION}
ENV NODE_PATH ${NVM_NODE_PATH}/lib/node_modules
ENV PATH ${NVM_NODE_PATH}/bin:$PATH

RUN npm install npm@7.24.2 -g
RUN npm install yarn -g

jac18281828 marked this conversation as resolved.
Show resolved Hide resolved
ARG PROJECT=did-eth
WORKDIR /workspaces/${PROJECT}

Expand Down
4 changes: 2 additions & 2 deletions packages/did-eth-registry/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@ To use the contract, we provide hardhat artifacts. Once you require the `ethr-di
object containing the JSON.

```javascript
const { EthereumDIDRegistry } = require('ethr-did-registry')
const { DIDRegistry } = require('ethr-did-registry')
```

You can use [`ethers.js`](https://github.com/ethers-io/ethers.js/) to utilize these artifacts.

```javascript
const { ethers } = require('ethers')
const DidReg = new ethers.Contract(registryAddress, EthereumDIDRegistry.abi)
const DidReg = new ethers.Contract(registryAddress, DIDRegistry.abi)
DidReg.connect(yourSignerOrProvider)
```

Expand Down
Loading