Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EIP1056Registry - standardized contract interface #60

Merged
merged 8 commits into from
Nov 2, 2023
Merged

EIP1056Registry - standardized contract interface #60

merged 8 commits into from
Nov 2, 2023

Conversation

jac18281828
Copy link
Collaborator

closes #57

  • renames registry to remove the word 'Ethereum'
  • upgrades solidity version to 0.8.15, a more recent and stable version
  • implements the EIP1056Registry interface
  • provides documentation for all contract functions

jac18281828
jac18281828 commented Oct 19, 2023
View reviewed changes
packages/did-eth-registry/Dockerfile

# python3.10 is required for node-gyp
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.10 is no longer required on the latest hardhat and node versions (solc 0.8.21)

mirceanis
mirceanis requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
I added some suggestions for a couple of inline docs that were wrong about the return type. Please fix those before we merge.

packages/did-eth-registry/Dockerfile Show resolved Hide resolved
packages/did-eth-registry/contracts/DIDRegistry.sol Outdated Show resolved Hide resolved
packages/did-eth-registry/contracts/DIDRegistry.sol Outdated Show resolved Hide resolved
packages/did-eth-registry/contracts/EIP1056Registry.sol Show resolved Hide resolved
packages/did-eth-registry/contracts/EIP1056Registry.sol Outdated Show resolved Hide resolved
jac18281828 and others added 4 commits October 30, 2023 12:28
@jac18281828 @mirceanis
Update packages/did-eth-registry/contracts/DIDRegistry.sol
9f35008 
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
@jac18281828 @mirceanis
Update packages/did-eth-registry/contracts/EIP1056Registry.sol
6ac08f5 
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
@jac18281828 @mirceanis
Update packages/did-eth-registry/contracts/EIP1056Registry.sol
a5b6cf7 
Co-authored-by: Mircea Nistor <mirceanis@gmail.com>
@jac18281828
review: rename internal contract functions to include _ to avoid name…
0d77ef6 
…space pollution
mirceanis
mirceanis approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@mirceanis mirceanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@mirceanis mirceanis merged commit f416855 into veramolabs:main Nov 2, 2023
1 check passed
@jac18281828 jac18281828 deleted the jac/doc branch November 2, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirceanis mirceanis mirceanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardized Contract Interface for Registry
2 participants
@jac18281828 @mirceanis