Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all dependency group #3354

Merged
merged 8 commits into from
Mar 11, 2024
Merged

Add all dependency group #3354

merged 8 commits into from
Mar 11, 2024

Conversation

jonmmease
Copy link
Contributor

@jonmmease jonmmease commented Mar 7, 2024

Closes #2818 and part of #3309

This PR adds a new all dependency group that contains the primary optional dependencies that we'd like most users of Altair to have installed by default.

Rather than duplicate dependencies across all and our existing dev group, I removed the optional runtime dependencies from dev and updated the development instructions to install both groups with pip install ".[all, dev]".

I updated the documentation to recommend installing the altair package with pip install "altair[all]".

@mattijn
Copy link
Contributor

mattijn commented Mar 7, 2024

Thanks @jonmmease! I opened vega/altair_tiles#36.

Hopefully it is possible that we can support Python 3.8 as well within altair_tiles, cc: @binste

@binste
Copy link
Contributor

binste commented Mar 10, 2024

I've just released altair_tiles 0.3.0 which supports Python 3.8 up to 3.12. Thanks Jon for this PR!

@jonmmease
Copy link
Contributor Author

Great, thanks @binste. I added altair_tiles back to the all group.

Copy link
Contributor

@mattijn mattijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jon, one suggestion!

@@ -9,7 +9,7 @@ Altair can be installed, along with the example datasets in vega_datasets_, usin

.. code-block:: bash

pip install altair vega_datasets
pip install "altair[all]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install "altair[all]"
pip install altair[all]

Since there is no usage of special characters, I think we don't need the double quotes here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The quotes are needed for zsh (because square brackets are used for pattern matching), which is the default shell on MacOS. See https://stackoverflow.com/questions/30539798/zsh-no-matches-found-requestssecurity. I think this approach should be valid across all major shells on windows and linux as well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. I did not know this. Thanks for explaining. Just ignore then!

@jonmmease
Copy link
Contributor Author

Thanks all, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create an extra_require group for soft dependencies
3 participants