Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: GitHub action include python-version 3.12 #3235

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Oct 20, 2023

Python 3.12 was released recently, this PR updates our GitHub action to also test against python 3.12. This PR is currently failing because pyarrow does not yet publish builds for python 3.12, see apache/arrow#37880.

By including python-version 3.12 I dropped 3.9 to avoid the number of tests that are run in parallel. So it becomes python-version: ["3.8", "3.10", "3.11", "3.12"], not sure if that is a good idea.

@jonmmease
Copy link
Contributor

By including python-version 3.12 I dropped 3.9 to avoid the number of tests that are run in parallel. So it becomes python-version: ["3.8", "3.10", "3.11", "3.12"], not sure if that is a good idea.

👍 Yeah, I think that's reasonable

@binste
Copy link
Contributor

binste commented Oct 20, 2023

Thanks! Sounds good to me too.

@binste
Copy link
Contributor

binste commented Oct 20, 2023

Could you add 3.12 also under classifiers in pyproject.toml?

@mattijn
Copy link
Contributor Author

mattijn commented Nov 2, 2023

Tests passing, merging

@mattijn mattijn merged commit 18aa513 into main Nov 2, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants