Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move tests and sphinxext outside folder application code #2792

Merged
merged 11 commits into from
Jan 2, 2023

Conversation

mattijn
Copy link
Contributor

@mattijn mattijn commented Dec 31, 2022

First attempt for #2788.
This also moves the sphinxext folder to the main folder.

All tests pass locally.


description what happens in this PR.

  • move and rename altair.examples to tests/examples_arguments_syntax
  • move all tests within altair into tests folder, keeping the same folder structure how these test files appeared.
  • move altair.sphinxext folder to sphinxext folder on main level
  • run pytest functions against tests folder instead of altair folder
  • add pytest-cov package to dependencies_dev.txt file, so the coverage functions also function in the Makefile
  • change the function name iter_examples to iter_examples_arguments_syntax
  • update the black and flake config pyproject.toml and setup.cfg to exclude the tests folder

@mattijn mattijn marked this pull request as ready for review January 1, 2023 13:24
@mattijn
Copy link
Contributor Author

mattijn commented Jan 1, 2023

@binste, can you have a look if this is OK?

All tests now also pass on Github Actions including building the docs. I think this is a nice improvement.

Then after this we can merge the test-file changes from https://github.com/altair-viz/altair/pull/2770/files into a folder examples_methods_syntax on equal level of examples_arguments_syntax in the tests folder.

@binste
Copy link
Contributor

binste commented Jan 2, 2023

Agree, this is a great improvement to the package structure, thanks @mattijn!

Could you also update the pytest commands in https://github.com/altair-viz/altair/blob/master/Makefile? Apart from that it looks good to me. I also built the documentation locally and all examples rendered fine.

@mattijn mattijn changed the title move tests to test folder move tests and sphinxext outside folder application code Jan 2, 2023
@mattijn
Copy link
Contributor Author

mattijn commented Jan 2, 2023

Thanks for the feedback @binste. I updated the makefile, I also had to add the pytest-cov package to get output for the coverage functions. All tests pass, merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants