Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up airport maps #2634

Merged
merged 6 commits into from
Jul 3, 2022
Merged

Clean up airport maps #2634

merged 6 commits into from
Jul 3, 2022

Conversation

palewire
Copy link
Contributor

@palewire palewire commented Jul 1, 2022

Fixes #2629 by cutting a duplicate map and reframing the airports map more clearly as our best, most direct point map example.

@mattijn
Copy link
Contributor

mattijn commented Jul 2, 2022

I agree on the lack of diversity on the maps! But I think the techniques behind these approaches are quite different. Especially when reading the related PR: #1407 and issue: #1366 of https://altair-viz.github.io/gallery/airports_count.html.

Instead of deleting, we should improve the title and description to reflect more the goal and technique of the chart.

@palewire
Copy link
Contributor Author

palewire commented Jul 3, 2022

I've added it back in with a more specific name

@mattijn mattijn merged commit 6648a3b into vega:master Jul 3, 2022
@mattijn
Copy link
Contributor

mattijn commented Jul 3, 2022

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There are two U.S. Airports maps. There probably shouldn't be.
2 participants