Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove webdriver default argument to save #2466

Merged
merged 3 commits into from
Dec 28, 2022

Conversation

Midnighter
Copy link
Contributor

This PR addresses altair-viz/altair_saver#72

@mattijn
Copy link
Contributor

mattijn commented Dec 27, 2022

Thanks for this PR @Midnighter! Since this PR there was merged another PR: #2701 that made vl-convert the new default for saving Altair Charts to png/svg as it does not require external dependencies. Github docs here: https://github.com/altair-viz/altair/blob/master/doc/user_guide/saving_charts.rst#png-svg-and-pdf-format. Do you still think it is useful to have this PR included within Altair?

@Midnighter
Copy link
Contributor Author

I don't know to be honest. It's been a while since I looked at this and I haven't really followed altair development since then.

If the webdriver is still used at all, then I think it might be useful to apply this PR such that the webdriver can pick the available rendering engine rather than being forced to use chrome. Ultimately, it's up to you/maintainers to decide whether it's still useful. I won't be cross if you just close it.

@mattijn
Copy link
Contributor

mattijn commented Dec 28, 2022

I updated this branch to be in-sync with the main repo. Since the GitHub Actions all pass, tested against a chrome webdriver, I am OK in merging this. Thanks @Midnighter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants