Make selection-style configurable #73
Conversation
hrdl-github
changed the title
pdf-view-selection-style. A default value of word might be desirable, as selection is usually intended to select entire words is perceptually faster than glyph-based selection.
|
Thanks for this PR @lennonhill . I'm a bit busy in Jan and Feb, I'll try and make time for this as early as possible. I'm adding this to the 1.1.0 milestone release, planned in Apr. |
|
Sure. Thanks for taking over maintainership of this project! |
|
Just tested this out and wanted to say that this is a great idea! Using |
vedang
added
the
new feature implementation
|
I'm moving away from pdf-tools. I'd love to see this one getting merged while I'm still around to fix anything that requires fixing. No pressure though, thanks for putting in the effort to maintain this project. |
|
Hey @hrdl-github , I'll keep some time aside on the weekend and get it done. Thanks for the message and heads-up. I'm sorry to see you go. Would be great if you can write up feedback on vedang dot manerikar at google's email service |
|
Thanks. What kind of feedback do you have in mind? Feedback on pdf-tools or why I leave? |
|
Feedback on why you leave, where you are going, |
|
Initial review and testing went great. There are some minor changes and commit squashing that I can do. I want to test it a little bit more and review it once again tomorrow. I don't see any changes required at the moment, but will confirm this tomorrow. |
|
Thanks. Feel free to squash and to make any changes you'd like. |
|
Thanks, squashed and merged |
Thanks to the stellar work by @hrdl-github in #73, we can now change the default unit of selection from `glyph` to `word`. This speeds up selection significantly. Look at the documentation of `pdf-view-selection-style` for more information. Closes: #87
Make selection-style configurable via `pdf-view-selection-style`. A default value of `word` might be desirable, as selection is usually intended to select entire words is perceptually faster than glyph-based selection. This affects selections and highlights, but not search. Limitation: The selection type is fixed for all currently selected regions. Selecting multiple regions with different selection styles at the same time would require storing the selection style for every region and replacing the protocol for `cmd_addannot` with a more flexible one, e.g. the keyword-based one used by `cmd_renderpage`. Closes: vedang#73
Thanks to the stellar work by @hrdl-github in vedang#73, we can now change the default unit of selection from `glyph` to `word`. This speeds up selection significantly. Look at the documentation of `pdf-view-selection-style` for more information. Closes: vedang#87
Make selection-style configurable via `pdf-view-selection-style`. A default value of `word` might be desirable, as selection is usually intended to select entire words is perceptually faster than glyph-based selection. This affects selections and highlights, but not search. Limitation: The selection type is fixed for all currently selected regions. Selecting multiple regions with different selection styles at the same time would require storing the selection style for every region and replacing the protocol for `cmd_addannot` with a more flexible one, e.g. the keyword-based one used by `cmd_renderpage`. Closes: vedang#73
Thanks to the stellar work by @hrdl-github in vedang#73, we can now change the default unit of selection from `glyph` to `word`. This speeds up selection significantly. Look at the documentation of `pdf-view-selection-style` for more information. Closes: vedang#87
Make selection-style configurable via pdf-view-selection-style. A default value of word might be desirable, as selection is usually intended to select entire words is perceptually faster than glyph-based selection.
This affects selections and highlights, but not search. Limitation: the selection type is fixed for all currently selected regions. Selecting multiple regions with different selection styles at the same time would require storing the selection style for every region and replacing the protocol for
cmd_addannotwith a more flexible one, e.g. the keyword-based one used bycmd_renderpage.