Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Having a default_hs_url shouldn't leave you at the server picker #8840

Closed
turt2live opened this issue Feb 20, 2019 · 2 comments
Closed

Having a default_hs_url shouldn't leave you at the server picker #8840

turt2live opened this issue Feb 20, 2019 · 2 comments
Assignees
@jryans
Labels
A-Authentication A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

image

I would expect to be left at a place where I can enter a username for the server, not verify the URLs.

Config:

{
  "default_hs_url": "https://dev.t2host.io"
}

URL visited: /register
@jryans
Copy link
Collaborator

jryans commented Feb 20, 2019

Ah yeah, I agree. Same for the case of default_server_name as well.

@jryans jryans added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround 001 mistake label A-Registration and removed 001 mistake label labels Feb 21, 2019
@bwindels bwindels mentioned this issue Feb 21, 2019
Closed
41 tasks
@jryans jryans self-assigned this Feb 21, 2019
jryans added a commit to jryans/matrix-react-sdk that referenced this issue Feb 21, 2019
@jryans
Skip server details on registration with a default HS
fe14141 
If Riot has been configured with a `default_hs_url` (or `default_server_name`,
which then sets a default HS URL), then skip the server details on registration
by default.

Fixes element-hq/element-web#8840
@jryans jryans mentioned this issue Feb 21, 2019
Merged
@jryans
Copy link
Collaborator

jryans commented Feb 22, 2019

Fixed in matrix-org/matrix-react-sdk#2675

@jryans jryans closed this as completed Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jryans jryans

Labels
A-Authentication A-Registration P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jryans @turt2live @lampholder