add test for internal/errors/tensorflow #982

vankichi · 2021-02-04T03:04:11Z

Signed-off-by: vankichi kyukawa315@gmail.com

Wait for reply from @datelier

Description:

Added the test for internal/errors/tensorflow.go and the comment for each function.
grammar check has passed.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.7
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.13.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2021-02-04T03:04:30Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

internal/errors/tensorflow_test.go

github-actions · 2021-02-04T03:10:39Z

internal/errors/tensorflow_test.go

+		},
+		{
+			name: "return an ErrInputLength error when i and f is zero value",
+			args: args{


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

github-actions · 2021-02-04T03:10:39Z

internal/errors/tensorflow_test.go

+			}
+		})
+	}
+}


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofumpt-ed (gofumpt)

github-actions · 2021-02-04T03:10:39Z

internal/errors/tensorflow_test.go

+			}
+		})
+	}
+}


🚫 [golangci] _{reported by reviewdog 🐶}
File is not gofumpt-ed (gofumpt)

vankichi · 2021-02-04T03:18:31Z

/format

vdaas-ci · 2021-02-04T03:19:52Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

codecov · 2021-02-04T03:20:12Z

Codecov Report

Merging #982 (59bab6e) into master (6e80d7c) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #982      +/-   ##
==========================================
- Coverage   14.53%   14.46%   -0.08%     
==========================================
  Files         493      493              
  Lines       27967    27967              
==========================================
- Hits         4065     4045      -20     
- Misses      23661    23676      +15     
- Partials      241      246       +5

Impacted Files	Coverage Δ
internal/errors/tensorflow.go	`100.00% <ø> (+100.00%)`	⬆️
internal/db/storage/blob/s3/reader/reader.go	`63.04% <0.00%> (-31.53%)`	⬇️
internal/errgroup/group.go	`92.42% <0.00%> (-1.52%)`	⬇️
internal/worker/worker.go	`82.29% <0.00%> (-1.05%)`	⬇️
internal/worker/queue.go	`100.00% <0.00%> (+5.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e80d7c...887a61b. Read the comment docs.

internal/errors/tensorflow_test.go

kevindiu

LGTM

kevindiu · 2021-02-08T04:51:20Z

/rebase
/format
/approve

vdaas-ci · 2021-02-08T04:51:59Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-tensorflow

vdaas-ci · 2021-02-08T04:55:09Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci

[APPROVED] This PR is approved by kevindiu.

kevindiu · 2021-02-08T09:27:57Z

/rebase
/format
/approve

vdaas-ci · 2021-02-08T09:28:35Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-tensorflow

Signed-off-by: vankichi <kyukawa315@gmail.com>

Signed-off-by: vdaas-ci <ci@vdaas.org>

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci · 2021-02-08T09:29:42Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci

[APPROVED] This PR is approved by kevindiu.

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests labels Feb 4, 2021

vankichi requested review from hlts2 and kevindiu February 4, 2021 03:04

github-actions bot added the priority/low label Feb 4, 2021

vankichi self-assigned this Feb 4, 2021

github-actions bot reviewed Feb 4, 2021

View reviewed changes

internal/errors/tensorflow_test.go Show resolved Hide resolved

vankichi changed the title ~~[WIP] add test for internal/errors/tensorflow~~ add test for internal/errors/tensorflow Feb 4, 2021

vankichi marked this pull request as ready for review February 4, 2021 11:17

hlts2 previously approved these changes Feb 8, 2021

View reviewed changes

kevindiu previously approved these changes Feb 8, 2021

View reviewed changes

vdaas-ci dismissed stale reviews from kevindiu and hlts2 via b3878b0 February 8, 2021 04:52

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-tensorflow branch from 6d27f35 to b3878b0 Compare February 8, 2021 04:52

vdaas-ci previously approved these changes Feb 8, 2021

View reviewed changes

vankichi and others added 3 commits February 8, 2021 09:28

✅ add test for internal/errors/tensorflow

8d21254

Signed-off-by: vankichi <kyukawa315@gmail.com>

🤖 Update license headers / Format go codes and yaml files

ffec29e

Signed-off-by: vdaas-ci <ci@vdaas.org>

✅ fix based on ci

4501359

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ add parallel running

887a61b

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci dismissed their stale review via 887a61b February 8, 2021 09:28

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-tensorflow branch from b3878b0 to 887a61b Compare February 8, 2021 09:28

vdaas-ci approved these changes Feb 8, 2021

View reviewed changes

kevindiu merged commit 81c93d3 into master Feb 8, 2021

kevindiu deleted the test/internal/add-newtest-for-errors-tensorflow branch February 8, 2021 09:50

This was referenced Feb 9, 2021

[patch] Bug fix on StreamGetObject API and DNS cache expiration / refactor net connection #986

Merged

[patch] v1.0.2 Release #998

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add test for internal/errors/tensorflow #982

add test for internal/errors/tensorflow #982

vankichi commented Feb 4, 2021 •

edited

Loading

vdaas-ci commented Feb 4, 2021

github-actions bot Feb 4, 2021

github-actions bot Feb 4, 2021

github-actions bot Feb 4, 2021

vankichi commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

codecov bot commented Feb 4, 2021 •

edited

Loading

kevindiu left a comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

add test for internal/errors/tensorflow #982

add test for internal/errors/tensorflow #982

Conversation

vankichi commented Feb 4, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Feb 4, 2021

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

github-actions bot Feb 4, 2021

Choose a reason for hiding this comment

vankichi commented Feb 4, 2021

vdaas-ci commented Feb 4, 2021

codecov bot commented Feb 4, 2021 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci commented Feb 8, 2021

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Feb 4, 2021 •

edited

Loading

codecov bot commented Feb 4, 2021 •

edited

Loading