Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.free nil pointer failure in ngt cgo due to create index hang up #930

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Jan 17, 2021

Signed-off-by: kpango kpango@vdaas.org

Description:

this PR includes 2 bugfix & 2 feature
bugfix

  1. os.free nil pointer failure in ngt cgo due to create index hang up
  2. grpc client stream close error

feature

  1. show configuration and version information on debug print when server startup
  2. rewrite godoc badge.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #930 (bcfcd1d) into master (2990012) will decrease coverage by 0.09%.
The diff coverage is 18.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #930      +/-   ##
==========================================
- Coverage   16.43%   16.33%   -0.10%     
==========================================
  Files         470      470              
  Lines       23075    23094      +19     
==========================================
- Hits         3792     3773      -19     
- Misses      19047    19079      +32     
- Partials      236      242       +6     
Impacted Files Coverage Δ
internal/net/grpc/stream.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 0.00% <0.00%> (ø)
pkg/gateway/lb/usecase/vald.go 0.00% <ø> (ø)
internal/backoff/backoff.go 40.00% <10.00%> (-1.38%) ⬇️
internal/runner/runner.go 88.33% <54.54%> (-2.58%) ⬇️
internal/db/storage/blob/s3/reader/reader.go 63.04% <0.00%> (-31.53%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (-1.05%) ⬇️
internal/errgroup/group.go 93.93% <0.00%> (+1.51%) ⬆️
internal/worker/queue.go 98.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2990012...bcfcd1d. Read the comment docs.

Signed-off-by: kpango <kpango@vdaas.org>
@kpango kpango requested a review from rinx January 18, 2021 00:54
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'll check it on my local cluster.

Makefile.d/client.mk Outdated Show resolved Hide resolved
pkg/gateway/lb/usecase/vald.go Outdated Show resolved Hide resolved
kpango and others added 3 commits January 18, 2021 09:56
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: kpango <kpango@vdaas.org>
Signed-off-by: kpango <kpango@vdaas.org>
@github-actions github-actions bot added size/L and removed size/M labels Jan 18, 2021
Signed-off-by: kpango <kpango@vdaas.org>
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work in my local environment but it may be caused by the environmental problem.

@kpango
Copy link
Collaborator Author

kpango commented Jan 18, 2021

In addition to the comments, @rinx said, v0.0.66 also has this potential problem which we will have to check more in the environment later.

@kpango kpango merged commit c34930e into master Jan 18, 2021
@kpango kpango deleted the bugfix/agent-ngt/nil-pointer-in-ngt-cgo-due-to-create-index-hang-up branch January 18, 2021 05:47
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants