Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Docker build command to update latest tags & nightly label #890

Merged
merged 2 commits into from
Jan 20, 2021

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Dec 16, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Revised Docker build command on CI to update latest tags on version releases.
Also, I updated the CI to put "version=nightly" label to vald_app_version_info Prometheus exporter.

Temporarily the base branch is feature/apis/v1-new-design, but it is okay to merge this PR into master after #826 is merged into master. Once #826 merged into master, the base branch will be changed to master.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx rinx force-pushed the feature/apis/v1-new-design-update-docker-image-tag branch 3 times, most recently from 8de4418 to db9df0b Compare December 23, 2020 07:01
@rinx rinx force-pushed the feature/apis/v1-new-design-update-docker-image-tag branch from db9df0b to 8bb9191 Compare December 24, 2020 02:42
@rinx rinx force-pushed the feature/apis/v1-new-design-update-docker-image-tag branch from 8bb9191 to d983752 Compare January 6, 2021 02:24
@rinx rinx force-pushed the feature/apis/v1-new-design-update-docker-image-tag branch 2 times, most recently from f945652 to ec112de Compare January 12, 2021 01:54
Base automatically changed from feature/apis/v1-new-design to master January 12, 2021 06:25
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the feature/apis/v1-new-design-update-docker-image-tag branch from ec112de to d2a393e Compare January 20, 2021 04:54
@github-actions github-actions bot added size/S and removed size/S labels Jan 20, 2021
@rinx rinx marked this pull request as ready for review January 20, 2021 05:05
@rinx rinx requested a review from kpango January 20, 2021 05:05
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 88a8de3 into master Jan 20, 2021
@kpango kpango deleted the feature/apis/v1-new-design-update-docker-image-tag branch January 20, 2021 06:27
@rinx
Copy link
Contributor Author

rinx commented Jan 20, 2021

@kpango thanks 😄

@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants