Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create unit test guideline #869

Merged
merged 38 commits into from
Jan 19, 2021

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Dec 7, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I created unit test guideline.
This guideline show the unit test strategies, and Vald unit test strategy.
And, I update coding guideline about unit test naming and input values which will be used fro unit test.

Grammar check is already done.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 7, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

docs/contributing/coding-style.md Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
@vankichi vankichi changed the title [WIP] create unit test guideline [R.I.S] create unit test guideline Dec 22, 2020
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
docs/contributing/coding-style.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry my suggestion may not pass grammar test

docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
docs/contributing/unit-test-guideline.md Outdated Show resolved Hide resolved
kevindiu
kevindiu previously approved these changes Jan 12, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi and others added 24 commits January 19, 2021 05:21
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentaion/docs/create-unittest-guideline branch from 061eb0f to 7e4ed4d Compare January 19, 2021 05:21
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

@kevindiu kevindiu merged commit 6adeefb into master Jan 19, 2021
@kevindiu kevindiu deleted the documentaion/docs/create-unittest-guideline branch January 19, 2021 06:00
@vdaas-ci vdaas-ci mentioned this pull request Jan 29, 2021
18 tasks
@kpango kpango mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants