Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for cassandra error #865

Merged
merged 33 commits into from
Dec 22, 2020
Merged

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Dec 3, 2020

Description:

I implemented the test for Cassandra's error.

grammar check passed*

Related

https://github.com/vdaas/vald/projects/3#card-50354274

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #865 (d0f743a) into master (f72ff79) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #865      +/-   ##
==========================================
- Coverage   18.85%   18.80%   -0.05%     
==========================================
  Files         423      422       -1     
  Lines       19600    19572      -28     
==========================================
- Hits         3696     3681      -15     
+ Misses      15685    15676       -9     
+ Partials      219      215       -4     
Impacted Files Coverage Δ
internal/errors/cassandra.go 100.00% <ø> (+100.00%) ⬆️
internal/errors/compressor.go 0.00% <0.00%> (-100.00%) ⬇️
internal/db/storage/blob/s3/s3.go 0.00% <0.00%> (-94.29%) ⬇️
internal/net/http/client/client.go 0.00% <0.00%> (-89.48%) ⬇️
internal/worker/worker.go 83.33% <0.00%> (ø)
internal/net/grpc/client.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 0.00% <0.00%> (ø)
internal/db/storage/blob/s3/option.go 100.00% <0.00%> (ø)
internal/db/storage/blob/s3/reader/option.go 100.00% <0.00%> (ø)
internal/db/storage/blob/s3/writer/option.go 100.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933cba5...df214aa. Read the comment docs.

@hlts2 hlts2 self-assigned this Dec 3, 2020
@hlts2 hlts2 marked this pull request as ready for review December 7, 2020 01:10
@hlts2 hlts2 requested a review from kevindiu December 7, 2020 02:25
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
internal/errors/cassandra.go Outdated Show resolved Hide resolved
kevindiu
kevindiu previously approved these changes Dec 7, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi December 7, 2020 06:03
kevindiu
kevindiu previously approved these changes Dec 16, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2 and others added 23 commits December 21, 2020 08:30
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@github-actions github-actions bot dismissed stale reviews from vankichi and kevindiu via df214aa December 21, 2020 08:30
@github-actions github-actions bot force-pushed the test/internal/errors-cassandra branch from d4c67c0 to df214aa Compare December 21, 2020 08:30
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 2696dd3 into master Dec 22, 2020
@vankichi vankichi deleted the test/internal/errors-cassandra branch December 22, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants