Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/internal/nosql/cassandra test #809

Merged
merged 9 commits into from
Nov 10, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Oct 30, 2020

Description:

This PR implements cassandra test.
It also include the following changes:

  1. [Refactor] Create ClusterConfig mock implementation for the testing
  2. [Refactor] Separate events struct definition for the testing
  3. [Improvement] Avoid runtime instantiation of WhiteListHostFilter
  4. [Bugfix] Use dcHost in DataCentreHostFilter

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/nosql/cassandra-test

@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@codecov
Copy link

codecov bot commented Oct 30, 2020

Codecov Report

Merging #809 (4a2dc28) into master (baeb365) will increase coverage by 0.60%.
The diff coverage is 78.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   17.37%   17.97%   +0.60%     
==========================================
  Files         420      421       +1     
  Lines       19500    19500              
==========================================
+ Hits         3388     3505     +117     
+ Misses      15905    15787     -118     
- Partials      207      208       +1     
Impacted Files Coverage Δ
internal/db/nosql/cassandra/cassandra.go 97.43% <76.92%> (+97.43%) ⬆️
internal/db/nosql/cassandra/cassandra_mock.go 100.00% <100.00%> (ø)
internal/worker/worker.go 83.33% <0.00%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5fb94...4eb7c8a. Read the comment docs.

@kevindiu kevindiu requested a review from hlts2 November 2, 2020 05:38
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/nosql/cassandra-test

@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/nosql/cassandra-test

@vdaas-ci
Copy link
Collaborator

[REBASE] Failed to rebase.

@vankichi
Copy link
Contributor

/format
/approve

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

@vankichi vankichi merged commit a89ddb6 into master Nov 10, 2020
@vankichi vankichi deleted the test/internal/nosql/cassandra-test branch November 10, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants