Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more effective Close function for internal/core #764

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Oct 12, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #764 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #764      +/-   ##
==========================================
- Coverage   16.77%   16.73%   -0.04%     
==========================================
  Files         421      420       -1     
  Lines       19530    19476      -54     
==========================================
- Hits         3276     3260      -16     
+ Misses      16025    15995      -30     
+ Partials      229      221       -8     
Impacted Files Coverage Δ
internal/net/net.go
internal/worker/worker.go 83.33% <0.00%> (+1.04%) ⬆️
internal/errgroup/group.go 93.93% <0.00%> (+1.51%) ⬆️
internal/db/storage/blob/s3/reader/reader.go 100.00% <0.00%> (+32.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0804f...3fa24d9. Read the comment docs.

@kpango kpango merged commit 6cd738f into master Oct 13, 2020
@kpango kpango deleted the feature/internal-core/add-property-and-object-space-flush-when-core.Close branch October 13, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants