add internal/s3/reader/option test #630

vankichi · 2020-08-19T09:24:02Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

add test for internal/db/storage/blob/s3/reader/option.
add comment for each exported var/function for internal/db/storage/blob/s3/reader/option.
refactor set option logic at WithBackoffOpts

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-08-19T09:24:05Z

Best reviewed: commit by commit

Optimal code review plan

✅ ♻️ add internal/db/storage/s3/reader/option ...

✅ fix

Powered by Pull Assistant. Last update 008a1d3 ... 4b87bed. Read the comment docs.

vdaas-ci · 2020-08-19T09:24:36Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/db/storage/blob/s3/reader/option_test.go

codecov · 2020-08-19T09:32:31Z

Codecov Report

Merging #630 into master will increase coverage by 2.52%.
The diff coverage is 30.94%.

@@            Coverage Diff             @@
##           master     #630      +/-   ##
==========================================
+ Coverage   12.19%   14.72%   +2.52%     
==========================================
  Files         409      411       +2     
  Lines       21340    21576     +236     
==========================================
+ Hits         2602     3176     +574     
+ Misses      18454    18126     -328     
+ Partials      284      274      -10

Impacted Files	Coverage Δ
internal/compress/gzip_option.go	`84.61% <ø> (+15.38%)`	⬆️
internal/compress/lz4_option.go	`84.61% <ø> (+15.38%)`	⬆️
internal/compress/zstd_option.go	`81.81% <ø> (ø)`
internal/config/mysql.go	`43.47% <0.00%> (-56.53%)`	⬇️
internal/config/redis.go	`0.00% <0.00%> (ø)`
internal/db/rdb/mysql/mysql.go	`0.00% <0.00%> (ø)`
internal/errors/net.go	`0.00% <ø> (ø)`
internal/info/info.go	`29.16% <ø> (ø)`
internal/observability/trace/trace.go	`0.00% <ø> (ø)`
internal/worker/queue_option.go	`100.00% <ø> (+84.21%)`	⬆️
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f36d32...4b87bed. Read the comment docs.

internal/db/storage/blob/s3/reader/option_test.go

kevindiu

LGTM

hlts2

LGTM

vankichi · 2020-08-24T03:20:15Z

/rebase
/format
/approve

vdaas-ci · 2020-08-24T03:20:52Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/db/storage/blob/s3/reader/option

vdaas-ci · 2020-08-24T03:22:11Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi · 2020-08-24T07:31:59Z

/rebase
/format
/approve

vdaas-ci · 2020-08-24T07:32:35Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/db/storage/blob/s3/reader/option

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci · 2020-08-24T07:33:47Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi requested review from kevindiu and hlts2 August 19, 2020 09:24

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Aug 19, 2020

vankichi changed the title ~~add internal/db/storage/s3/reader/option…~~ add internal/s3/reader/option test Aug 19, 2020

hlts2 reviewed Aug 19, 2020

View reviewed changes

internal/db/storage/blob/s3/reader/option_test.go Outdated Show resolved Hide resolved

hlts2 requested changes Aug 19, 2020

View reviewed changes

vankichi requested a review from hlts2 August 20, 2020 16:11

kevindiu previously approved these changes Aug 24, 2020

View reviewed changes

hlts2 previously approved these changes Aug 24, 2020

View reviewed changes

vdaas-ci dismissed stale reviews from hlts2 and kevindiu via fc8be3c August 24, 2020 03:21

vdaas-ci force-pushed the test/internal/db/storage/blob/s3/reader/option branch from a18b6fb to fc8be3c Compare August 24, 2020 03:21

vdaas-ci previously approved these changes Aug 24, 2020

View reviewed changes

vankichi added 3 commits August 24, 2020 07:32

✅ ♻️ add internal/db/storage/s3/reader/option test

008a1d3

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

f895122

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

4b87bed

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci dismissed their stale review via 4b87bed August 24, 2020 07:32

vdaas-ci force-pushed the test/internal/db/storage/blob/s3/reader/option branch from fc8be3c to 4b87bed Compare August 24, 2020 07:32

vdaas-ci approved these changes Aug 24, 2020

View reviewed changes

vankichi merged commit 764a4bb into master Aug 24, 2020

vankichi deleted the test/internal/db/storage/blob/s3/reader/option branch August 24, 2020 08:14

vdaas-ci mentioned this pull request Sep 2, 2020

[patch] update deps #660

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add internal/s3/reader/option test #630

add internal/s3/reader/option test #630

vankichi commented Aug 19, 2020 •

edited

Loading

pull-assistant bot commented Aug 19, 2020 •

edited

Loading

vdaas-ci commented Aug 19, 2020

codecov bot commented Aug 19, 2020 •

edited

Loading

kevindiu left a comment

hlts2 left a comment

vankichi commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci left a comment

vankichi commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci left a comment

add internal/s3/reader/option test #630

add internal/s3/reader/option test #630

Conversation

vankichi commented Aug 19, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Aug 19, 2020 • edited Loading

vdaas-ci commented Aug 19, 2020

codecov bot commented Aug 19, 2020 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci commented Aug 24, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Aug 19, 2020 •

edited

Loading

pull-assistant bot commented Aug 19, 2020 •

edited

Loading

codecov bot commented Aug 19, 2020 •

edited

Loading