Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation/performance/loadtest #610

Merged
merged 15 commits into from
Aug 4, 2020
Merged

Documentation/performance/loadtest #610

merged 15 commits into from
Aug 4, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Aug 3, 2020 •
edited
Loading

Description:

This PR includes a new document for the load test.
The PR was created but the PR name was bad so I created this new PR.
old PR: #593

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@pull-assistant
Copy link

pull-assistant bot commented Aug 3, 2020 •
edited
Loading

Score: 0.83

Best reviewed: commit by commit

Optimal code review plan (1 warning)

     draft

     remove unused file

     add overview of benchmark

     update

     apply suggestion

     update

     fix grammar and indent

     fix

apply suggestions

docs/performance/benchmark.md 67% changes removed in fix comments

     fix

     fix comments

     fix

     fix format

     fix

     fix

Powered by Pull Assistant. Last update 523d096 ... adc1801. Read the comment docs.

@kevindiu kevindiu mentioned this pull request Aug 3, 2020
Closed
18 tasks
github-actions[bot]
github-actions bot reviewed Aug 3, 2020
View reviewed changes
docs/performance/loadtest.md Show resolved Hide resolved
docs/performance/loadtest.md Show resolved Hide resolved
@kevindiu
Copy link
Contributor Author

kevindiu commented Aug 3, 2020

/rebase

@kevindiu kevindiu requested a review from hlts2 August 3, 2020 07:46
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 3, 2020

[REBASE] Rebase triggered by kevindiu for branch: documentation/performance/loadtest

@vdaas-ci vdaas-ci force-pushed the documentation/performance/loadtest branch from 8d04c02 to 70f615b Compare August 3, 2020 07:47
@kevindiu kevindiu requested a review from vankichi August 3, 2020 08:35
hlts2
hlts2 reviewed Aug 4, 2020
View reviewed changes
docs/performance/benchmark.md Outdated Show resolved Hide resolved
hlts2
hlts2 reviewed Aug 4, 2020
View reviewed changes
docs/performance/loadtest.md Outdated Show resolved Hide resolved
@kevindiu kevindiu requested a review from hlts2 August 4, 2020 01:22
hlts2
hlts2 previously approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Aug 4, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/performance/loadtest

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Aug 4, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit bb35dd9 into master Aug 4, 2020
@vankichi vankichi deleted the documentation/performance/loadtest branch August 4, 2020 08:48
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@vankichi vankichi vankichi approved these changes

@hlts2 hlts2 hlts2 approved these changes

@vdaas-ci vdaas-ci vdaas-ci approved these changes

Assignees
No one assigned
Labels
priority/low size/L type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevindiu @vdaas-ci @vankichi @hlts2