[bugfix] fix agent sidecar behavior when index files are updated

[rinx]

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Current version v0.0.48, when agent-sidecar detects the changes in index files, it terminates itself immediately because the implementation is wrong.
In this PR, i've fixed it.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     🐛 fix agent sidecar behavior

Powered by Pull Assistant. Last update d2da9ad ... d2da9ad. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #598 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #598      +/-   ##
==========================================
- Coverage   11.79%   11.79%   -0.01%     
==========================================
  Files         407      407              
  Lines       21229    21231       +2     
==========================================
  Hits         2505     2505              
- Misses      18447    18449       +2     
  Partials      277      277              

Impacted Files	Coverage Δ
pkg/agent/sidecar/service/observer/observer.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98074e3...d2da9ad. Read the comment docs.

[kpango]

LGTM