Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fix behavior when index path is empty #596

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 28, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

from v0.0.47, when agent.ngt.index_path is empty, agent-ngt returns [FATAL]: remove .: invalid argument error and exit immediately.
the cause of this problem is the forgotten empty string check codes.
so i added a empty string check to WithIndexPath function.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🐛 fix behavior when index path is empty

Powered by Pull Assistant. Last update df490be ... df490be. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #596 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   11.80%   11.79%   -0.01%     
==========================================
  Files         407      407              
  Lines       21227    21229       +2     
==========================================
- Hits         2505     2504       -1     
- Misses      18445    18448       +3     
  Partials      277      277              
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/option.go 12.76% <0.00%> (-0.28%) ⬇️
internal/errgroup/group.go 93.42% <0.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf5754...df490be. Read the comment docs.

@rinx rinx marked this pull request as ready for review July 28, 2020 10:53
@rinx rinx requested a review from kpango July 28, 2020 10:53
@kpango
Copy link
Collaborator

kpango commented Jul 28, 2020

LGTM

@kpango kpango merged commit 12db552 into master Jul 28, 2020
@kpango kpango deleted the bugfix/agent-ngt/fix-behavior-when-empty-idx-path branch July 28, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants