Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass tparse by tee command #562

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 9, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

add tee command to pass tparse tests.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 9, 2020

Score: 0.92

Best reviewed: commit by commit


Optimal code review plan (1 warning)

⚗️ pass tparse by true command

.github/workflows/test.yml 67% changes removed in 🎨 revise

     🎨 split runs

     🎨 revise

     🎨 revise

Powered by Pull Assistant. Last update fe7d316 ... 7abbb9d. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 9, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the ci/run-tests/pass-tparse-results-by-true-command branch from 3f683a0 to fe7d316 Compare July 9, 2020 01:29
rinx added 3 commits July 9, 2020 10:56
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx requested a review from vankichi July 9, 2020 02:23
@rinx rinx changed the title pass tparse by true command pass tparse by tee command Jul 9, 2020
@vankichi
Copy link
Contributor

vankichi commented Jul 9, 2020

/approve

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 845c43e into master Jul 9, 2020
@vankichi vankichi deleted the ci/run-tests/pass-tparse-results-by-true-command branch July 9, 2020 02:40
@rinx rinx restored the ci/run-tests/pass-tparse-results-by-true-command branch July 9, 2020 06:17
@rinx rinx deleted the ci/run-tests/pass-tparse-results-by-true-command branch July 9, 2020 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants