Added test case for `internal/info` pacakge. #514

hlts2 · 2020-06-24T06:59:06Z

Description:

I added a test case for the internal/info package.
However, I'm not able to reach some code because I'm calling runtime.Caller directly.
Therefore, I skipped the tests related to the parts other than initialization.
As a future move, I make runtime.Callder subordinate to another structure and change the implementation code to get the information via the interface. After making the changes, I implement the tests for that part.
The following is target code.
https://github.com/vdaas/vald/blob/master/internal/info/info.go#L153-L160

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-06-24T06:59:08Z

Best reviewed: commit by commit

Optimal code review plan

feat: info pacakge test

feat: add test case for initialize function

Update internal/info/info.go

Powered by Pull Assistant. Last update b1f1d58 ... f41caa8. Read the comment docs.

hlts2 · 2020-06-24T07:00:17Z

/rebase

vdaas-ci · 2020-06-24T07:01:19Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/info

codecov · 2020-06-24T07:07:24Z

Codecov Report

Merging #514 into master will increase coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #514      +/-   ##
=========================================
+ Coverage    8.86%   9.03%   +0.16%     
=========================================
  Files         402     402              
  Lines       20831   20831              
=========================================
+ Hits         1847    1882      +35     
+ Misses      18731   18696      -35     
  Partials      253     253

Impacted Files	Coverage Δ
internal/info/info.go	`29.16% <ø> (+29.16%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e1f1e8...f41caa8. Read the comment docs.

internal/info/info_test.go

kevindiu · 2020-06-24T08:37:21Z

@hlts2 Seems some test case is not completed.

internal/info/info_test.go

vankichi · 2020-06-24T09:15:40Z

How do you think add error case or default params case?

hlts2 · 2020-06-25T01:46:28Z

/rebase

vdaas-ci · 2020-06-25T01:47:00Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/info

internal/info/info_test.go

kevindiu · 2020-06-25T06:35:40Z

Please add comments to info.go.

kevindiu · 2020-06-25T06:39:10Z

seems testString() and other test is not completed.

hlts2 · 2020-06-29T01:11:06Z

/rebase

vdaas-ci · 2020-06-29T01:12:09Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/info

github-actions · 2020-06-29T03:04:01Z

internal/info/info.go

@@ -45,6 +46,7 @@ type Detail struct {
 	PrepOnce          sync.Once    `json:"-" yaml:"-"`
 }

+// StackTrace represents stacktrace infomation about url, function name, file, line ..etc.


[golangci] _{reported by reviewdog 🐶}
infomation is a misspelling of information (misspell)

kevindiu · 2020-06-29T04:47:43Z

/rebase

kevindiu · 2020-06-29T04:48:17Z

LGTM but please fix #514 (comment) first :)

vdaas-ci · 2020-06-29T04:48:19Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/info

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

internal/info/info.go

Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-06-30T02:42:57Z

/rebase
/format
/approve

vdaas-ci · 2020-06-30T02:43:32Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/info

vdaas-ci · 2020-06-30T02:44:16Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

hlts2 requested a review from kevindiu June 24, 2020 06:59

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Jun 24, 2020

vdaas-ci force-pushed the test/internal/info branch from 2b03782 to 1c4105d Compare June 24, 2020 07:01

kevindiu reviewed Jun 24, 2020

View reviewed changes

internal/info/info_test.go Outdated Show resolved Hide resolved

vankichi reviewed Jun 24, 2020

View reviewed changes

internal/info/info_test.go Outdated Show resolved Hide resolved

github-actions bot reviewed Jun 25, 2020

View reviewed changes

internal/info/info_test.go Show resolved Hide resolved

internal/info/info_test.go Show resolved Hide resolved

internal/info/info_test.go Show resolved Hide resolved

internal/info/info_test.go Show resolved Hide resolved

internal/info/info_test.go Show resolved Hide resolved

vdaas-ci force-pushed the test/internal/info branch from 25c51b8 to 4a1e910 Compare June 29, 2020 01:12

github-actions bot reviewed Jun 29, 2020

View reviewed changes

hlts2 added 3 commits June 29, 2020 04:48

feat: info pacakge test

b1f1d58

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

feat: add test case for initialize function

a2a1a23

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

feat: add go-cmp

6a1effe

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

hlts2 added 3 commits June 29, 2020 04:48

feat: use go-cmp

f3c9ead

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: test case name

cdcc7c8

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

feat: comment

571097f

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci force-pushed the test/internal/info branch from ccb2691 to 571097f Compare June 29, 2020 04:48

kevindiu reviewed Jun 29, 2020

View reviewed changes

internal/info/info.go Outdated Show resolved Hide resolved

Update internal/info/info.go

f41caa8

Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>

kevindiu approved these changes Jun 29, 2020

View reviewed changes

vankichi approved these changes Jun 30, 2020

View reviewed changes

vdaas-ci approved these changes Jun 30, 2020

View reviewed changes

vankichi merged commit 58ac8c1 into master Jun 30, 2020

vankichi deleted the test/internal/info branch June 30, 2020 02:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test case for `internal/info` pacakge. #514

Added test case for `internal/info` pacakge. #514

hlts2 commented Jun 24, 2020 •

edited

Loading

pull-assistant bot commented Jun 24, 2020 •

edited

Loading

hlts2 commented Jun 24, 2020

vdaas-ci commented Jun 24, 2020

codecov bot commented Jun 24, 2020 •

edited

Loading

kevindiu commented Jun 24, 2020

vankichi commented Jun 24, 2020

hlts2 commented Jun 25, 2020

vdaas-ci commented Jun 25, 2020

kevindiu commented Jun 25, 2020

kevindiu commented Jun 25, 2020

hlts2 commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

github-actions bot Jun 29, 2020

kevindiu commented Jun 29, 2020

kevindiu commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

kevindiu left a comment

vankichi left a comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci left a comment

Added test case for internal/info pacakge. #514

Added test case for internal/info pacakge. #514

Conversation

hlts2 commented Jun 24, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jun 24, 2020 • edited Loading

hlts2 commented Jun 24, 2020

vdaas-ci commented Jun 24, 2020

codecov bot commented Jun 24, 2020 • edited Loading

Codecov Report

kevindiu commented Jun 24, 2020

vankichi commented Jun 24, 2020

hlts2 commented Jun 25, 2020

vdaas-ci commented Jun 25, 2020

kevindiu commented Jun 25, 2020

kevindiu commented Jun 25, 2020

hlts2 commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

github-actions bot Jun 29, 2020

Choose a reason for hiding this comment

kevindiu commented Jun 29, 2020

kevindiu commented Jun 29, 2020

vdaas-ci commented Jun 29, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci commented Jun 30, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

Added test case for `internal/info` pacakge. #514

Added test case for `internal/info` pacakge. #514

hlts2 commented Jun 24, 2020 •

edited

Loading

pull-assistant bot commented Jun 24, 2020 •

edited

Loading

codecov bot commented Jun 24, 2020 •

edited

Loading