Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CopyBuffer to copy.go #2167

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Add CopyBuffer to copy.go #2167

merged 1 commit into from
Sep 7, 2023

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Sep 6, 2023

Add CopyBuffer to copy.go

Description:

SSIA

Related Issue:

Versions:

  • Go Version: 1.21.0
  • Docker Version: 20.10.8
  • Kubernetes Version: v1.28.1
  • NGT Version: 2.1.3

Checklist:

Special notes for your reviewer:

[WIP] add CopyBuffer to copy.go

Signed-off-by: kpango <kpango@vdaas.org>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 6, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@kpango kpango requested review from a team, kmrmt and ykadowak and removed request for a team September 6, 2023 03:12
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage is 35.71% of modified lines.

Files Changed Coverage
internal/io/copy.go 35.71%

📢 Thoughts on this report? Let us know!.

@kpango kpango merged commit ed6118a into main Sep 7, 2023
70 of 71 checks passed
@kpango kpango deleted the refactor/io/copy branch September 7, 2023 01:08
@hlts2 hlts2 mentioned this pull request Sep 13, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
ykadowak added a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants