fix make k8s/metrics/jaeger/deploy failure #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/makefile
team/sre
|
I think it would be better to use curl and send an Empty Body and wait for a 400 Badrequest to be returned. |
Deploying with
|
| Latest commit: |
db0e0fc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e90134fc.vald.pages.dev |
| Branch Preview URL: | https://bugfix-makefile-k8s-jaeger-d.vald.pages.dev |
vankichi
requested review from
a team,
hlts2 and
ykadowak
and removed request for
a team
|
/rebase |
|
[REBASE] Rebase triggered by kmrmt for branch: bugfix/makefile/k8s-jaeger-deployment-failure |
|
[REBASE] Failed to rebase. |
kmrmt
force-pushed
the
bugfix/makefile/k8s-jaeger-deployment-failure
branch
from
67d5660
to
db0e0fc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When running
make k8s/metrics/jaeger/deploy, in my environment, executingkubectl apply -f k8s/metrics/jaeger/jaeger.yamlfails with errors below.I watched logs, but I could not find the related error.
So it is my opinion, even if it checks the condition using
kubectl wait --for=condition=ready pod -l app.kubernetes.io/name=jaeger-operator --timeout=60s, the endpoint will not be ready depending on the performance of the computer.Finally, in my environment, it could deploy in less than 3 seconds in most situation. And, to be sure, I estimated the buffer to be 5 seconds.
Related Issue:
Versions:
Checklist:
Special notes for your reviewer: