Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add save index operation log #2048

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jun 5, 2023

Description:

I have added the log for the save index operation.

Related Issue:

#2039

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.11

Checklist:

Special notes for your reviewer:

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 5, 2023

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 requested review from a team, kpango and datelier and removed request for a team June 5, 2023 02:35
@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (152ac56) 29.52% compared to head (49d722b) 29.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2048      +/-   ##
==========================================
- Coverage   29.52%   29.50%   -0.02%     
==========================================
  Files         366      366              
  Lines       34634    34664      +30     
==========================================
+ Hits        10224    10226       +2     
- Misses      23973    24001      +28     
  Partials      437      437              
Impacted Files Coverage Δ
pkg/agent/core/ngt/service/ngt.go 21.65% <0.00%> (-0.60%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

datelier
datelier previously approved these changes Jun 5, 2023
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-pages
Copy link

cloudflare-pages bot commented Jun 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 49d722b
Status: ✅  Deploy successful!
Preview URL: https://d44a3738.vald.pages.dev
Branch Preview URL: https://refactor-agent-add-save-inde.vald.pages.dev

View logs

@hlts2 hlts2 requested review from kpango and datelier June 5, 2023 06:44
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/M and removed size/S labels Jun 5, 2023
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango June 5, 2023 07:41
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2023

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jun 7, 2023

Profile Report

typevald-agent-ngtvald-lb-gatewayvald-discoverervald-manager-index
cpu
heap
other images

@vankichi vankichi merged commit e67a833 into main Jun 7, 2023
@vankichi vankichi deleted the refactor/agent/add-save-index-log branch June 7, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants