Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create README for each docker image #2014

Merged
merged 10 commits into from
May 15, 2023

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Apr 25, 2023

Description:

I have created README for each Docker image.
The purpose is to copy these documents to the hub.docker and makes a more user-friendly page for each Docker image.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

All files have the requirement section for using each image.
However, I'm not sure about everything, please check out more carefully and review 🙏

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 25, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6608bb8
Status: ✅  Deploy successful!
Preview URL: https://147e029a.vald.pages.dev
Branch Preview URL: https://documentation-dockers-create.vald.pages.dev

View logs

@kpango
Copy link
Collaborator

kpango commented Apr 25, 2023

Overall looks good.
It would be better to add environment or requirements eg.CPU, AVX, etc...

@vankichi vankichi force-pushed the documentation/dockers/create-docker-readme branch 5 times, most recently from a1ad940 to 25288b1 Compare April 26, 2023 05:54
kpango
kpango previously approved these changes Apr 26, 2023
@github-actions github-actions bot removed the size/M label Apr 26, 2023
hlts2
hlts2 previously approved these changes Apr 26, 2023
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevindiu
kevindiu previously approved these changes Apr 26, 2023
ykadowak
ykadowak previously approved these changes Apr 26, 2023
datelier
datelier previously approved these changes Apr 26, 2023
@vankichi vankichi dismissed stale reviews from datelier, ykadowak, kevindiu, hlts2, and kpango via 18b892d April 26, 2023 07:18
@vankichi vankichi force-pushed the documentation/dockers/create-docker-readme branch from 25288b1 to 18b892d Compare April 26, 2023 07:18
@github-actions github-actions bot added size/M and removed size/M labels Apr 26, 2023
@github-actions github-actions bot added size/XL and removed size/L labels May 8, 2023
@vankichi vankichi changed the title Create docker readme template Create README for each docker image May 8, 2023
ykadowak
ykadowak previously approved these changes May 8, 2023
hlts2
hlts2 previously approved these changes May 9, 2023
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kpango
kpango previously approved these changes May 9, 2023
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datelier
datelier previously approved these changes May 9, 2023
kevindiu
kevindiu previously approved these changes May 9, 2023
@vankichi vankichi dismissed stale reviews from kevindiu, datelier, kpango, hlts2, and ykadowak via 050de1d May 10, 2023 08:46
vankichi and others added 8 commits May 11, 2023 15:24
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi force-pushed the documentation/dockers/create-docker-readme branch from 3e767a9 to 2030d1a Compare May 11, 2023 06:24
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi merged commit bf68d44 into main May 15, 2023
@vankichi vankichi deleted the documentation/dockers/create-docker-readme branch May 15, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants