Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect error output of gen-test chatopts command #2004

Merged
merged 2 commits into from
Apr 11, 2023

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Apr 11, 2023

Description:

This PR fixes the incorrect error output of /gen-test chatopts command.
Also it fixes some steps execute on all PR and causing error output on PR.

Related Issue:

Versions:

  • Go Version: 1.20.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 2.0.9

Checklist:

Special notes for your reviewer:

Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@kevindiu kevindiu changed the title Fix gen-test command error output [WIP] Fix gen-test command error output Apr 11, 2023
@kevindiu
Copy link
Contributor Author

/gen-test

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Generating missing test files triggered by kevindiu.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Apr 11, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29101a8
Status: ✅  Deploy successful!
Preview URL: https://ec62fd7c.vald.pages.dev
Branch Preview URL: https://ci-fix-chatopts-gen-test-com.vald.pages.dev

View logs

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

@kevindiu kevindiu changed the title [WIP] Fix gen-test command error output Fix incorrect error output of gen-test chatopts command Apr 11, 2023
@kevindiu kevindiu marked this pull request as ready for review April 11, 2023 01:45
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.83 🎉

Comparison is base (9503588) 29.48% compared to head (618ed48) 30.32%.

❗ Current head 618ed48 differs from pull request most recent head 29101a8. Consider uploading reports for the commit 29101a8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2004      +/-   ##
==========================================
+ Coverage   29.48%   30.32%   +0.83%     
==========================================
  Files         365      356       -9     
  Lines       34436    32994    -1442     
==========================================
- Hits        10153    10004     -149     
+ Misses      23865    22585    -1280     
+ Partials      418      405      -13     

see 13 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vdaas-ci
Copy link
Collaborator

[GEN TEST] Failed to generate tests. Error: Object

@kevindiu kevindiu changed the title Fix incorrect error output of gen-test chatopts command [WIP] Fix incorrect error output of gen-test chatopts command Apr 11, 2023
@kevindiu kevindiu marked this pull request as draft April 11, 2023 02:49
Signed-off-by: kevindiu <kevin_diu@yahoo.com.hk>
@github-actions github-actions bot added size/S and removed size/S labels Apr 11, 2023
@kevindiu kevindiu changed the title [WIP] Fix incorrect error output of gen-test chatopts command Fix incorrect error output of gen-test chatopts command Apr 11, 2023
@kevindiu kevindiu marked this pull request as ready for review April 11, 2023 08:18
@kevindiu kevindiu requested review from vankichi and hlts2 April 11, 2023 08:21
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu merged commit c39b23a into main Apr 11, 2023
@kevindiu kevindiu deleted the ci/fix-chatopts-gen-test-command branch April 11, 2023 08:23
@ykadowak ykadowak mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants