🚨 Fix lint. #2
Merged
🚨 Fix lint. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM thanks! @rinx |
rinx
added a commit
that referenced
this pull request
Sep 8, 2020
# This is the 1st commit message: :wrench: pass CXXFLAGS to CGO_CXXFLAGS... Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #2: :construction: wip Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #3: :wrench: add CGO_CFLAGS, CGO_CPPFLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #4: :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
vdaas-ci
pushed a commit
that referenced
this pull request
Sep 8, 2020
# This is the 1st commit message: :wrench: pass CXXFLAGS to CGO_CXXFLAGS... Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #2: :construction: wip Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #3: :wrench: add CGO_CFLAGS, CGO_CPPFLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #4: :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
kpango
pushed a commit
that referenced
this pull request
Sep 8, 2020
* # This is a combination of 4 commits. # This is the 1st commit message: :wrench: pass CXXFLAGS to CGO_CXXFLAGS... Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #2: :construction: wip Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #3: :wrench: add CGO_CFLAGS, CGO_CPPFLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> # This is the commit message #4: :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> * :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :construction: wip Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :wrench: add CGO_CFLAGS, CGO_CPPFLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :fire: remove useless line Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
takuyaymd
pushed a commit
to takuyaymd/vald
that referenced
this pull request
Dec 17, 2022
…h-api [WIP]Add flush api to Agent
kpango
added a commit
that referenced
this pull request
Apr 5, 2023
Signed-off-by: kpango <kpango@vdaas.org>
vankichi
pushed a commit
that referenced
this pull request
Apr 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed some irregular patterns in Makefile.