Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete stackdriver dependencies #1761

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Aug 4, 2022

Description:

WHAT

I have deleted stackdriver dependencies.

WHY

we need to remove stackdriver because we no longer use it.

Result
  • When executed on the master branch
go run ./main.go -f sample.yaml 
0.78s user 0.32s system 16% cpu 6.656 total
  • When executed on the this branch
go run ./main.go -f sample.yaml 
0.60s user 0.24s system 219% cpu 0.382 total

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2022

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2022

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1761 (ad818bd) into main (dba4202) will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1761      +/-   ##
==========================================
+ Coverage   31.37%   31.64%   +0.27%     
==========================================
  Files         381      376       -5     
  Lines       32698    32231     -467     
==========================================
- Hits        10259    10201      -58     
+ Misses      22037    21636     -401     
+ Partials      402      394       -8     
Impacted Files Coverage Δ
internal/config/observability.go 100.00% <ø> (ø)
internal/observability/observability.go 0.00% <ø> (ø)
internal/observability/observability_option.go 3.70% <ø> (+0.92%) ⬆️
pkg/agent/core/ngt/service/option.go 89.57% <0.00%> (-1.85%) ⬇️
internal/core/algorithm/ngt/ngt.go 63.59% <0.00%> (-0.65%) ⬇️
internal/worker/worker.go 85.15% <0.00%> (+0.78%) ⬆️
internal/errgroup/group.go 95.00% <0.00%> (+1.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 4, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ad818bd
Status: ✅  Deploy successful!
Preview URL: https://05a96f82.vald.pages.dev
Branch Preview URL: https://feature-delete-stackdriver-p.vald.pages.dev

View logs

@hlts2 hlts2 self-assigned this Aug 4, 2022
kpango
kpango previously approved these changes Aug 4, 2022
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from datelier August 4, 2022 11:31
datelier
datelier previously approved these changes Aug 8, 2022
@kpango kpango changed the base branch from master to main August 8, 2022 07:10
@kpango kpango dismissed stale reviews from datelier and themself August 8, 2022 07:10

The base branch was changed.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango August 9, 2022 01:44
@hlts2 hlts2 requested a review from datelier August 9, 2022 01:44
@hlts2 hlts2 merged commit 2b5f4d5 into main Aug 9, 2022
@hlts2 hlts2 deleted the feature/delete-stackdriver-package branch August 9, 2022 07:37
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants