Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the images of agent page #1753

Merged
merged 7 commits into from
Aug 9, 2022
Merged

Update the images of agent page #1753

merged 7 commits into from
Aug 9, 2022

Conversation

taisuou
Copy link
Contributor

@taisuou taisuou commented Jul 28, 2022

Description:

fixed the images of vald agent page
https://vald.vdaas.org/docs/overview/component/agent/

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.18.3
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.7

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@taisuou taisuou requested review from kpango and vankichi July 28, 2022 04:52
@taisuou taisuou self-assigned this Jul 28, 2022
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@taisuou
Copy link
Contributor Author

taisuou commented Jul 28, 2022

ngt
sidecar_backup
sidecar_restore

@vankichi vankichi changed the title fix the images of agent page Update the images of agent page Jul 28, 2022
@cloudflare-pages
Copy link

cloudflare-pages bot commented Aug 1, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0c7a9e9
Status: ✅  Deploy successful!
Preview URL: https://401cca5b.vald.pages.dev
Branch Preview URL: https://design-fix-agent-image.vald.pages.dev

View logs

@taisuou
Copy link
Contributor Author

taisuou commented Aug 1, 2022

fixed colors of the arrows.
ngt
sidecar_backup
sidecar_restore

vankichi
vankichi previously approved these changes Aug 1, 2022
@taisuou
Copy link
Contributor Author

taisuou commented Aug 2, 2022

Adjusting the flow left to right, I fixed the image of restore.
And the text flowing blow is added.

"Read the backup file when restoring is requested."

Please check the layout and the added text.

sidecar_restore

@vankichi
Copy link
Contributor

vankichi commented Aug 2, 2022

@taisuou
Get the backup file when restoring is requested would be better.

vankichi
vankichi previously approved these changes Aug 4, 2022
@vankichi vankichi changed the base branch from master to main August 8, 2022 05:56
@vankichi vankichi dismissed their stale review August 8, 2022 05:56

The base branch was changed.

@vankichi vankichi merged commit 1f91c63 into main Aug 9, 2022
@vankichi vankichi deleted the design/fix-agent-image branch August 9, 2022 06:20
@kevindiu kevindiu mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants