Add backoff metrics for grpc #1684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
|
[CHATOPS:HELP] ChatOps commands.
|
github-actions
bot
added
area/gateway/lb
area/internal
area/manager/index
team/set
hlts2
commented
Jun 2, 2022
| @@ -31,7 +31,7 @@ import ( | |||
| "github.com/vdaas/vald/internal/test/goleak" | |||
| ) | |||
|
|
|||
| func TestDo(t *testing.T) { | |||
| func TestDo_for_race(t *testing.T) { | |||
There was a problem hiding this comment.
I have fixed function name because of CI fails.
The reason why CI fails was because there was a same function in to the same package.
https://github.com/vdaas/vald/blob/master/internal/runner/runner_test.go#L284
Codecov Report
@@ Coverage Diff @@
## master #1684 +/- ##
==========================================
- Coverage 31.30% 31.26% -0.04%
==========================================
Files 374 377 +3
Lines 32591 32679 +88
==========================================
+ Hits 10202 10218 +16
- Misses 22002 22078 +76
+ Partials 387 383 -4
Continue to review full report at Codecov.
|
datelier
previously approved these changes
Jun 2, 2022
kpango
reviewed
Jun 2, 2022
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
![github-advanced-security[bot]](https://github.com/avatars/in/57789?s=60&v=4){kind=small}
| @@ -2004,7 +2004,7 @@ | |||
| } | |||
|
|
|||
| func (s *server) Remove(ctx context.Context, req *payload.Remove_Request) (res *payload.Object_Location, err error) { | |||
| ctx, span := trace.StartSpan(ctx, apiName+".Remove") | |||
| ctx, span := trace.StartSpan(ctx, apiName+"/"+vald.RemoveRPCName) | |||
Check warning
Code scanning / CodeQL
Useless assignment to local variable
| @@ -2140,7 +2140,7 @@ | |||
| } | |||
|
|
|||
| func (s *server) MultiRemove(ctx context.Context, reqs *payload.Remove_MultiRequest) (res *payload.Object_Locations, err error) { | |||
| ctx, span := trace.StartSpan(ctx, apiName+".MultiRemove") | |||
| ctx, span := trace.StartSpan(ctx, apiName+"/"+vald.MultiRemoveRPCName) | |||
Check warning
Code scanning / CodeQL
Useless assignment to local variable
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
datelier
approved these changes
Jun 6, 2022
This was referenced Jun 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
NOTE : This PR is mirror of #1666
WHAT
I have added the logic to be able to get backoff metrics.
This allows collection of backoff metrics (retry count) within each RPC request when observability and backoff are enabled
WHY
We are in the process of implementing CircuitBreaker, but first we need to get proper metrics on the backoffs that occur inside RPC requests.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: