fix comments and add decision table test cases

Signed-off-by: kevindiu <kevindiujp@gmail.com>
vdaas · Apr 13, 2022 · ab16eef · ab16eef
1 parent 053b7ce
commit ab16eef
Showing 1 changed file with 59 additions and 22 deletions.
diff --git a/pkg/agent/core/ngt/handler/grpc/handler_test.go b/pkg/agent/core/ngt/handler/grpc/handler_test.go
@@ -3393,8 +3393,8 @@ func Test_server_MultiInsert(t *testing.T) {
 				- case 1.2: MultiInsert 1 vector success (vector type is float32)
 				- case 1.3: MultiInsert 100 vector success (vector type is uint8)
 				- case 1.4: MultiInsert 100 vector success (vector type is float32)
-				- case 1.5: MultiInsert 0 vector fail (vector type is uint8)
-				- case 1.6: MultiInsert 0 vector fail (vector type is float32)
+				- case 1.5: MultiInsert 0 vector success (vector type is uint8)
+				- case 1.6: MultiInsert 0 vector success (vector type is float32)
 				- case 2.1: MultiInsert 1 vector with different dimension fail (vector type is uint8)
 				- case 2.2: MultiInsert 1 vector with different dimension fail (vector type is float32)
 				- case 3.1: MultiInsert 100 vector with 1 vector with different dimension fail (vector type is uint8)
@@ -3426,27 +3426,64 @@ func Test_server_MultiInsert(t *testing.T) {
 				- case 5.6: MultiInsert 100 vector with all vector with maximum dimension fail (vector type is float32)
 
 			- float32
-				- case 5: MultiInsert 100 vector with NaN value success (vector type is float32)
-
-			- case 6.1: MultiInsert 100 vector with 1 vector with nil insert request fail
-			- case 6.2: MultiInsert 100 vector with 50 vector with nil insert request fail
-			- case 6.3: MultiInsert 100 vector with all vector with nil insert request fail
-			- case 7.1: MultiInsert 100 vector with 1 vector with nil vector fail
-			- case 7.2: MultiInsert 100 vector with 50 vector with nil vector fail
-			- case 7.3: MultiInsert 100 vector with all vector with nil vector fail
-			- case 8.1: MultiInsert 100 vector with 1 vector with empty insert vector fail
-			- case 8.2: MultiInsert 100 vector with 50 vector with empty insert vector fail
-			- case 8.3: MultiInsert 100 vector with all vector with empty insert vector fail
-
-			*WIP*
+				- case 6: MultiInsert 100 vector with NaN value success (vector type is float32)
+
+			- case 7.1: MultiInsert 100 vector with 1 vector with nil insert request fail
+			- case 7.2: MultiInsert 100 vector with 50 vector with nil insert request fail
+			- case 7.3: MultiInsert 100 vector with all vector with nil insert request fail
+			- case 8.1: MultiInsert 100 vector with 1 vector with nil vector fail
+			- case 8.2: MultiInsert 100 vector with 50 vector with nil vector fail
+			- case 8.3: MultiInsert 100 vector with all vector with nil vector fail
+			- case 9.1: MultiInsert 100 vector with 1 vector with empty insert vector fail
+			- case 9.2: MultiInsert 100 vector with 50 vector with empty insert vector fail
+			- case 9.3: MultiInsert 100 vector with all vector with empty insert vector fail
+
 		- Decision Table Testing
-			- duplicated ID, duplicated vector, duplicated ID & vector
-				- case 1.1: MultiInsert duplicated request fail when SkipStrictExistCheck is false (duplicated ID)
-				- case 1.2: MultiInsert duplicated request success when SkipStrictExistCheck is false (duplicated vector)
-				- case 1.3: MultiInsert duplicated request fail when SkipStrictExistCheck is false (duplicated ID & vector)
-				- case 2.1: MultiInsert duplicated request fail when SkipStrictExistCheck is true (duplicated ID)
-				- case 2.2: MultiInsert duplicated request success when SkipStrictExistCheck is true (duplicated vector)
-				- case 2.3: MultiInsert duplicated request fail when SkipStrictExistCheck is true (duplicated ID & vector)
+			- duplicated ID
+				- case 1.1: MultiInsert 100 request with no duplicated ID success when SkipStrictExistCheck is false
+				- case 1.2: MultiInsert 100 request with 2 duplicated ID success when SkipStrictExistCheck is false
+				- case 1.3: MultiInsert 100 request with all duplicated vector success when SkipStrictExistCheck is false
+				- case 1.4: MultiInsert 100 request with no duplicated ID success when SkipStrictExistCheck is true
+				- case 1.5: MultiInsert 100 request with 2 duplicated ID success when SkipStrictExistCheck is true
+				- case 1.6: MultiInsert 100 request with all duplicated vector success when SkipStrictExistCheck is true
+			- duplicated vector
+				- case 2.1: MultiInsert 100 request with no duplicated vector success when SkipStrictExistCheck is false
+				- case 2.2: MultiInsert 100 request with 2 duplicated vector success when SkipStrictExistCheck is false
+				- case 2.3: MultiInsert 100 request with all duplicated vector success when SkipStrictExistCheck is false
+				- case 2.4: MultiInsert 100 request with no duplicated vector success when SkipStrictExistCheck is true
+				- case 2.5: MultiInsert 100 request with 2 duplicated vector success when SkipStrictExistCheck is true
+				- case 2.6: MultiInsert 100 request with all duplicated vector success when SkipStrictExistCheck is true
+			- duplicated ID & vector
+				- case 3.1: MultiInsert 100 request with no duplicated ID & vector success when SkipStrictExistCheck is false
+				- case 3.2: MultiInsert 100 request with 2 duplicated ID & vector success when SkipStrictExistCheck is false
+				- case 3.3: MultiInsert 100 request with all duplicated ID & vector success when SkipStrictExistCheck is false
+				- case 3.4: MultiInsert 100 request with no duplicated ID & vector success when SkipStrictExistCheck is true
+				- case 3.5: MultiInsert 100 request with 2 duplicated ID & vector success when SkipStrictExistCheck is true
+				- case 3.6: MultiInsert 100 request with all duplicated ID & vector success when SkipStrictExistCheck is true
+
+			// existed in NGT test cases
+			- existed ID
+				- case 4.1: MultiInsert 100 request with no existed ID success when SkipStrictExistCheck is false
+				- case 4.2: MultiInsert 100 request with 2 existed ID fail when SkipStrictExistCheck is false
+				- case 4.3: MultiInsert 100 request with all existed vector fail when SkipStrictExistCheck is false
+				- case 4.4: MultiInsert 100 request with no existed ID success when SkipStrictExistCheck is true
+				- case 4.5: MultiInsert 100 request with 2 existed ID fail when SkipStrictExistCheck is true
+				- case 4.6: MultiInsert 100 request with all existed vector fail when SkipStrictExistCheck is true
+			- existed vector
+				- case 4.1: MultiInsert 100 request with no existed vector success when SkipStrictExistCheck is false
+				- case 4.2: MultiInsert 100 request with 2 existed vector success when SkipStrictExistCheck is false
+				- case 4.3: MultiInsert 100 request with all existed vector success when SkipStrictExistCheck is false
+				- case 4.4: MultiInsert 100 request with no existed vector success when SkipStrictExistCheck is true
+				- case 4.5: MultiInsert 100 request with 2 existed vector success when SkipStrictExistCheck is true
+				- case 4.6: MultiInsert 100 request with all existed vector success when SkipStrictExistCheck is true
+			- existed ID & vector
+				- case 4.1: MultiInsert 100 request with no existed ID & vector success when SkipStrictExistCheck is false
+				- case 4.2: MultiInsert 100 request with 2 existed ID & vector fail when SkipStrictExistCheck is false
+				- case 4.3: MultiInsert 100 request with all existed ID & vector fail when SkipStrictExistCheck is false
+				- case 4.4: MultiInsert 100 request with no existed ID & vector success when SkipStrictExistCheck is true
+				- case 4.5: MultiInsert 100 request with 2 existed ID & vector fail when SkipStrictExistCheck is true
+				- case 4.6: MultiInsert 100 request with all existed ID & vector fail when SkipStrictExistCheck is true
+
 	*/
 	tests := []test{
 		// TODO test cases