more robust slideby classifier function handling #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the classifier function is pure everything works fine, but with state, `slideBy` might end up in an infinite loop. The reason: `slideBy` calls the classifier two times on the same item. If the second call returns a different value, `slideBy` will not advance anymore and iterate indefinitely on the same item.
Codecov Report
@@ Coverage Diff @@
## master #2642 +/- ##
============================================
- Coverage 92.89% 92.87% -0.02%
Complexity 5368 5368
============================================
Files 89 89
Lines 12785 12786 +1
Branches 1619 1619
============================================
- Hits 11876 11875 -1
- Misses 720 722 +2
Partials 189 189
Continue to review full report at Codecov.
|
danieldietrich
added
design/refactoring/improvement
«vavr-collection»
bug
and removed
design/refactoring/improvement
labels
danieldietrich
approved these changes
Apr 11, 2021
danieldietrich
pushed a commit
that referenced
this pull request
Jul 14, 2021
When the classifier function is pure everything works fine, but with state, `slideBy` might end up in an infinite loop. The reason: `slideBy` calls the classifier two times on the same item. If the second call returns a different value, `slideBy` will not advance anymore and iterate indefinitely on the same item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the classifier function is pure everything works fine, but with
state,
slideBymight end up in an infinite loop. The reason:slideBycalls the classifier two times on the same item. If the second call
returns a different value,
slideBywill not advance anymore anditerate indefinitely on the same item.