Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Restream Support #104

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Restream Support #104

wants to merge 9 commits into from

Conversation

vamsii777
Copy link

This PR adds support for Restream OAuth integration to the Imperial package.

Depends on

@vamsii777 vamsii777 marked this pull request as ready for review July 27, 2024 13:04
@fpseverino
Copy link
Member

You can remove the Tests/LinuxMain.swift file, as it is no longer needed. Also, I think you could use the Vapor CI workflow, like the one I added to PassKit.

fpseverino
fpseverino requested changes Jul 27, 2024
View reviewed changes
Copy link
Member

@fpseverino fpseverino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the testing and CI fix, you could update JWTKit to v5, although it may bring breaking changes.

Sources/ImperialCore/Routing/FederatedServiceRouter.swift Outdated Show resolved Hide resolved
@vamsii777
Copy link
Author

@fpseverino, Thanks for the feedback. Given that the current PR focuses on adding a new auth provider, it might be better to handle JWT updates in a separate PR. This will keep our changes focused and easier to review.

I'll create a new PR for updating JWTKit to v5 and address any potential breaking changes.

@vamsii777 @fpseverino
Fix Typo in Completion Handler Syntax
089ddfb 
Co-authored-by: Francesco Paolo Severino <96546612+fpseverino@users.noreply.github.com>
@0xTim
Copy link
Member

0xTim commented Jul 31, 2024

Just an FYI I'm going to be doing an Imperial code sprint next week to go through all the issues and PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpseverino fpseverino Awaiting requested review from fpseverino

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vamsii777 @fpseverino @0xTim @proggeramlug