Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: storage #634

Merged
merged 4 commits into from
Oct 8, 2023
Merged

refactor: storage #634

merged 4 commits into from
Oct 8, 2023

Conversation

ifplusor
Copy link
Collaborator

@ifplusor ifplusor commented Oct 8, 2023

What problem does this PR solve?

Problem Summary

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: James Yin <ywhjames@hotmail.com>
Signed-off-by: James Yin <ywhjames@hotmail.com>
Signed-off-by: James Yin <ywhjames@hotmail.com>
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #634 (24c2b89) into main (ee76217) will decrease coverage by 5.72%.
Report is 96 commits behind head on main.
The diff coverage is 3.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   57.07%   51.36%   -5.72%     
==========================================
  Files         190      259      +69     
  Lines       15191    19405    +4214     
==========================================
+ Hits         8670     9967    +1297     
- Misses       5884     8627    +2743     
- Partials      637      811     +174     
Flag Coverage Δ
unittests 51.36% <3.63%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/errors/app.go 30.90% <ø> (ø)
lib/bytes/escape.go 54.46% <ø> (ø)
lib/bytes/io.go 0.00% <ø> (ø)
lib/bytes/parse.go 7.14% <ø> (ø)
lib/bytes/unsafe.go 100.00% <ø> (ø)
lib/bytes/utf8.go 11.11% <ø> (ø)
lib/json/path/parse.go 49.41% <ø> (ø)
lib/json/path/path.go 0.00% <ø> (ø)
lib/json/path/segment.go 0.00% <ø> (ø)
lib/json/path/selector.go 0.00% <ø> (ø)
... and 30 more

... and 394 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9aff3e...24c2b89. Read the comment docs.

@ifplusor ifplusor merged commit 8cdd729 into vanus-labs:main Oct 8, 2023
4 of 6 checks passed
@ifplusor ifplusor deleted the refactor-storage branch October 8, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants