Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change json path library #345

Merged
merged 2 commits into from
Dec 15, 2022
Merged

feat: change json path library #345

merged 2 commits into from
Dec 15, 2022

Conversation

wenfengwang
Copy link
Contributor

What problem does this PR solve?

Issue Number: close N/a

Problem Summary

change JSON path library, https://cburgmer.github.io/json-path-comparison/

What is changed and how does it work?

https://cburgmer.github.io/json-path-comparison/

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Signed-off-by: wenfeng <sxian.wang@gmail.com>
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #345 (c3b97e3) into main (09f3748) will increase coverage by 0.25%.
The diff coverage is 61.57%.

❗ Current head c3b97e3 differs from pull request most recent head 24f4aa5. Consider uploading reports for the commit 24f4aa5 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   62.72%   62.97%   +0.25%     
==========================================
  Files         133      144      +11     
  Lines       12128    13116     +988     
==========================================
+ Hits         7607     8260     +653     
- Misses       3977     4268     +291     
- Partials      544      588      +44     
Impacted Files Coverage Δ
internal/controller/eventbus/block/block.go 56.09% <0.00%> (ø)
internal/controller/eventbus/server/instance.go 72.04% <ø> (ø)
internal/controller/eventbus/server/manager.go 66.66% <ø> (ø)
internal/controller/trigger/storage/secret.go 48.48% <ø> (ø)
...nternal/controller/trigger/storage/subscription.go 54.71% <ø> (ø)
...ernal/controller/trigger/storage/trigger_worker.go 63.41% <ø> (ø)
...rnal/primitive/interceptor/errinterceptor/error.go 0.00% <0.00%> (ø)
.../primitive/interceptor/memberinterceptor/member.go 0.00% <0.00%> (ø)
internal/primitive/vanus/id.go 19.84% <0.00%> (-0.49%) ⬇️
internal/raft/log/wal.go 100.00% <ø> (ø)
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d27b41...24f4aa5. Read the comment docs.

Signed-off-by: wenfeng <sxian.wang@gmail.com>
@wenfengwang wenfengwang mentioned this pull request Dec 15, 2022
@wenfengwang wenfengwang merged commit a8bb18f into main Dec 15, 2022
@wenfengwang wenfengwang deleted the feat-change-jsonpath-pkg branch December 15, 2022 17:44
wenfengwang added a commit that referenced this pull request Mar 23, 2023
* feat: change json path libary

Signed-off-by: wenfeng <sxian.wang@gmail.com>

* feat: fix lint

Signed-off-by: wenfeng <sxian.wang@gmail.com>

Signed-off-by: wenfeng <sxian.wang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants